minor: Remove redundant shift and offset operations in EndianUtils

[KishorMore-2005]

Removes redundant bit shift and arithmetic operations (<< 0, >> 0, + 0)
from EndianUtils methods. These operations have no effect on values and
were making the code unnecessarily verbose. No functional changes.

[garydgregory]

-1 and closing: I think this class was originally authored in this style for readability, which is subjective I'll grant.

[sebbASF]

Agreed: having the zeros in place shows that they are part of the sequence of values, rather than a special case.

This is obvious here:

commons-io/src/main/java/org/apache/commons/io/EndianUtils.java

Lines 122 to 125 in 4708e98

	return ((data[offset + 0] & 0xff) << 0) +
	((data[offset + 1] & 0xff) << 8) +
	((data[offset + 2] & 0xff) << 16) +
	((data[offset + 3] & 0xff) << 24);

Less so here:

commons-io/src/main/java/org/apache/commons/io/EndianUtils.java

Line 140 in 4708e98

return ((value1 & 0xff) << 0) + ((value2 & 0xff) << 8) + ((value3 & 0xff) << 16) + ((value4 & 0xff) << 24);

That instance seems to have lots its original layout:

commons-io/src/java/org/apache/commons/io/EndianUtils.java

Lines 390 to 393 in a330996

	return (int)( ( ( value1 & 0xff ) << 0 ) +
	( ( value2 & 0xff ) << 8 ) +
	( ( value3 & 0xff ) << 16 ) +
	( ( value4 & 0xff ) << 24 ) );

It might be worth resorting to the original layout throughout, but that is a separate issue.

[KishorMore-2005]

okay , Thank you for explanation!