Open
Conversation
Replace hardcoded Thread.sleep() calls in JMSDestinationTest with Awaitility-based polling where possible, and increase remaining sleep durations to accommodate CI environments under load. - testDurableSubscriber: increase sleep from 500ms to 2000ms - testMessageObserverExceptionHandling: increase sleep from 500ms to 2000ms - testTemporaryQueueDeletionUponReset: increase Awaitility atMost from 1s to 5s - testConnectionFactoryExceptionHandling: replace Thread.sleep(4000) with Awaitility polling on connectionsCreated counter - testBrokerExceptionHandling: replace Thread.sleep(2000) with Awaitility polling for broker connectivity, plus additional reconnect wait - testSessionsExceptionHandling: replace Thread.sleep(4000) with Awaitility polling on connectionsCreated counter (was shorter than 5x1000ms retry math) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread.sleep()calls with Awaitility-based polling where possible, and increase remaining sleep durations to accommodate CI environments under loadtestSessionsExceptionHandlingwhere the sleep (4s) was shorter than the minimum required time (5 failures x 1s retry = 5s)connectionsCreatedcounter in connection/session fault tests, and poll for broker connectivity after broker restartChanges
testDurableSubscriberThread.sleep(500)Thread.sleep(2000)testMessageObserverExceptionHandlingThread.sleep(500)Thread.sleep(2000)testTemporaryQueueDeletionUponResetatMost(1s)atMost(5s)testConnectionFactoryExceptionHandlingThread.sleep(4000)connectionsCreatedtestBrokerExceptionHandlingThread.sleep(500)+Thread.sleep(2000)Thread.sleep(2000)+ Awaitility broker connectivity poll +Thread.sleep(5000)testSessionsExceptionHandlingThread.sleep(4000)(too short)connectionsCreated >= 2Test plan
mvn -B test -pl rt/transports/jms -Dtest=JMSDestinationTestpasses (16 tests, 0 failures)mvn -B validate -pl rt/transports/jmspasses (no checkstyle/PMD violations)🤖 Generated with Claude Code