Skip to content

Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix AttachmentMtomChunkingTest port collision with AttachmentChunkingTest #2972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/AttachmentMtomChunkingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
import static org.junit.Assert.assertTrue;

public class AttachmentMtomChunkingTest extends AbstractAttachmentChunkingTest {
private static final String PORT = allocatePort(DownloadServer.class);
private static final String PORT = allocatePort(AttachmentMtomChunkingTest.class);
Copy link
Member

@reta reta Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great finding @gnodet , however I think we would have to address the cause:

  • allocatePort() sets two properties, with full class name, and simple class name
  • the conflict is apparently over simple class name

It would be beneficial to improve TestUtil to catch those conflicts (it can do it, properties are static), so the test suite fails to run and would need to be fixed. Wdyt?

private static final Logger LOG = LogUtils.getLogger(AttachmentMtomChunkingTest.class);

public static class DownloadServer extends AbstractBusTestServerBase {
Expand Down
Loading