[CXF-9209] UriInfoImpl#getMatchedResourceTemplate support variable Paths#2983
Open
jungm wants to merge 1 commit intoapache:mainfrom
Open
[CXF-9209] UriInfoImpl#getMatchedResourceTemplate support variable Paths#2983jungm wants to merge 1 commit intoapache:mainfrom
jungm wants to merge 1 commit intoapache:mainfrom
Conversation
reta
reviewed
Mar 23, 2026
| final List<URITemplate> templates = new LinkedList<>(); | ||
| String matchedResourceTemplate = getBaseUri().getPath(); | ||
|
|
||
| if (HttpUtils.isHttpRequest(message)) { |
Member
There was a problem hiding this comment.
@jungm I believe this is not the correct implementation since it captures the part of the URI which is outside of the JAX-RS scope. The test case from below is confirming that:
Message m = mockMessage("http://localhost:8080/app", "/foo/one/abc");
assertEquals("/app/foo/one/{name:[a-zA-Z][a-zA-Z_0-9]*}", u.getMatchedResourceTemplate());
I believe the /app should not be included in the resource template (it is managed externally, could be set by servlet container / application server / ...), it is reasonable to assume the correct template in this case should be /foo/one/{name:[a-zA-Z][a-zA-Z_0-9]*}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CXF-9209
TCK run is passing in TomEE with these changes