Skip to content

chore: add confirmation before tarball is released #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milenkovicm wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

chore: add confirmation before tarball is released #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dev/release/release-tarball.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ fi
version=$1
rc=$2

read -r -p "Proceed to release tarball for ${version}-rc${rc}? [y/N]: " answer
answer=${answer:-no}
if [ "${answer}" != "y" ]; then
echo "Cancelled tarball release!"
exit 1
fi
Comment on lines +46 to +51
Copy link
Member

@timsaucer timsaucer Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it further down in the script? That way it would get through all of the steps and ask to confirm just before committing. Also if we do that maybe change the text to something along the lines of "Generated release tarball at XXX. Proceed to commit to SVN?"

Copy link
Contributor Author

@milenkovicm milenkovicm Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense if the script was creating a tarball and performing some complex logic. However, it’s simply copying the existing tarball from dev to release without any tarball manipulation.

I've pushed this update across all other DataFusion repositories. It would make sense to me if we keep tarball-release.sh the same across projects.

If you’re keen on change I’m happy to adapt but I’m feeling a bit stressed about testing it after this morning. 😀


tmp_dir=tmp-apache-datafusion-python-dist

echo "Recreate temporary directory: ${tmp_dir}"
Expand Down