Merged
Conversation
Contributor
|
Thanks @kevinjqliu I don't know too much about this process, but it seems like the release artifact Has several more files than this. Should include all of them? Also, do we need to update the corresponding css as well? Do you think we should install |
kevinjqliu
force-pushed
the
kevinjqliu/fix-bootstrap
branch
from
e469030 to
acc571e
Compare
Contributor
Author
|
Updated These are the only 3 bootstrap files in the repo: I found the instructions on upgrading bootstrap Lines 63 to 73 in 8c89c73 I tested this locally (had to hard-refresh browser to clear cache). The previous error disappears. |
Closed
Contributor
Author
|
This also fixes #117! The bootstrap error caused the hamburger menu to not function correctly |
alamb
approved these changes
Mar 16, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @kevinjqliu
I double checked that the sha's match
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion-site$ curl -sSfL https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/css/bootstrap.min.css | md5
1b1cb0e2be9a21f091a87691f20c6300
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion-site$ curl -sSfL https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/js/bootstrap.bundle.min.js | md5
5cc1b73e70520fa84b1846afe0ec8fb6
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion-site$ curl -sSfL https://cdn.jsdelivr.net/npm/bootstrap@5.3.8/dist/js/bootstrap.bundle.min.js.map | md5
c38a44bc4f4f4b94a2ea27c61bb8d34f
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion-site$ md5 content/css/bootstrap.min.css content/js/bootstrap.bundle.min.js content/js/bootstrap.bundle.min.js.map
MD5 (content/css/bootstrap.min.css) = 1b1cb0e2be9a21f091a87691f20c6300
MD5 (content/js/bootstrap.bundle.min.js) = 5cc1b73e70520fa84b1846afe0ec8fb6
MD5 (content/js/bootstrap.bundle.min.js.map) = c38a44bc4f4f4b94a2ea27c61bb8d34f
Contributor
|
I also verified the error is gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running locally, i noticed this console error:
Upgrading bootstrap fixed the error.
Taken from bootstrap repo, tag v5.3.8:
Heres what I ran: