Oracle dialect#2110
Closed
xitep wants to merge 2 commits into
Closed
Conversation
xitep
force-pushed
the
oracle-dialect
branch
from
1fcc4ef to
3af91ea
Compare
xitep
force-pushed
the
oracle-dialect
branch
from
3af91ea to
331e056
Compare
Contributor
|
@xitep could we split the PR into smaller more focused ones? its easier for me to make the time to review it that way. I think we can have this one just introduce the dialect (basically only implementing the required trait methods), then follow up PRs can introduce any precedence changes, and another for the string support |
Contributor
Author
|
sure, will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2101