Merged
Conversation
iffyio
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetExpris a directly recursive data-structure throughSetExpr::SetOperationSelect(without necessary going throughQueryfirst)Visitorimpl has no chance to observe when aSELECTstarts and ends during the traversalThe motivation is that
SELECTs often introduce aliases which are valid only for that particularSELECT.This change allows effectively to determine the scope of a (nested)
SELECTusingVisitor/Mut.Alternatively we could drop the
SetExpr::Selectvariant and replace it entirely with the existingSetExpr::Query; after all, aSelectis aQuery's body. (My personal preference, however, would be to keep the current structure as it makes the AST easier to follow / navigate / more expressive.)