Revert Teradata dialect#2381
Closed
iffyio wants to merge 1 commit into
Closed
Conversation
Contributor
|
FWIW - there is a preference to keep it in, even if not complete - it is still helpful with initial take on Teradata workloads |
Contributor
Author
|
Alright, will leave it in then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commits #2309 and #2329 that I introduced with base teradata dialect support.
I needed the dialect support for my use case and the plan was to further extend the dialect going forward. But I later opted for a less invasive approach that relies on the parser's public apis instead. As a result I no longer have the plans to extend the dialect and it feels wrong to keep it in the repo if its going to be half-implemented and no one else interested in it.
So here I figure to remove it. I can also leave as is if the preference is to keep it