Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/mysql_2693_compound_datetime_units.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT EXTRACT(YEAR_MONTH FROM d), DATE_ADD(d, INTERVAL '1-2' YEAR_MONTH), d + INTERVAL '1 2' DAY_HOUR FROM t
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/mysql_2693_compound_interval_units.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT DATE_ADD(d, INTERVAL '1-2' YEAR_MONTH) FROM t
33 changes: 33 additions & 0 deletions src/ast/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,28 @@ pub enum DateTimeField {
TimezoneMinute,
/// `TIMEZONE_REGION`
TimezoneRegion,
/// `SECOND_MICROSECOND` (MySQL)
SecondMicrosecond,
/// `MINUTE_MICROSECOND` (MySQL)
MinuteMicrosecond,
/// `MINUTE_SECOND` (MySQL)
MinuteSecond,
/// `HOUR_MICROSECOND` (MySQL)
HourMicrosecond,
/// `HOUR_SECOND` (MySQL)
HourSecond,
/// `HOUR_MINUTE` (MySQL)
HourMinute,
/// `DAY_MICROSECOND` (MySQL)
DayMicrosecond,
/// `DAY_SECOND` (MySQL)
DaySecond,
/// `DAY_MINUTE` (MySQL)
DayMinute,
/// `DAY_HOUR` (MySQL)
DayHour,
/// `YEAR_MONTH` (MySQL)
YearMonth,
/// `NODATETIME` indicates no date/time part
NoDateTime,
/// Arbitrary abbreviation or custom date-time part.
Expand Down Expand Up @@ -503,6 +525,17 @@ impl fmt::Display for DateTimeField {
DateTimeField::TimezoneHour => write!(f, "TIMEZONE_HOUR"),
DateTimeField::TimezoneMinute => write!(f, "TIMEZONE_MINUTE"),
DateTimeField::TimezoneRegion => write!(f, "TIMEZONE_REGION"),
DateTimeField::SecondMicrosecond => write!(f, "SECOND_MICROSECOND"),
DateTimeField::MinuteMicrosecond => write!(f, "MINUTE_MICROSECOND"),
DateTimeField::MinuteSecond => write!(f, "MINUTE_SECOND"),
DateTimeField::HourMicrosecond => write!(f, "HOUR_MICROSECOND"),
DateTimeField::HourSecond => write!(f, "HOUR_SECOND"),
DateTimeField::HourMinute => write!(f, "HOUR_MINUTE"),
DateTimeField::DayMicrosecond => write!(f, "DAY_MICROSECOND"),
DateTimeField::DaySecond => write!(f, "DAY_SECOND"),
DateTimeField::DayMinute => write!(f, "DAY_MINUTE"),
DateTimeField::DayHour => write!(f, "DAY_HOUR"),
DateTimeField::YearMonth => write!(f, "YEAR_MONTH"),
DateTimeField::NoDateTime => write!(f, "NODATETIME"),
DateTimeField::Custom(custom) => write!(f, "{custom}"),
}
Expand Down
4 changes: 4 additions & 0 deletions src/dialect/generic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ impl Dialect for GenericDialect {
true
}

fn supports_compound_date_time_fields(&self) -> bool {
true
}

fn allow_extract_single_quotes(&self) -> bool {
true
}
Expand Down
9 changes: 9 additions & 0 deletions src/dialect/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1107,6 +1107,15 @@ pub trait Dialect: Debug + Any {
false
}

/// Returns true if this dialect supports compound date and time units
/// such as `YEAR_MONTH`, `DAY_HOUR` or `SECOND_MICROSECOND`, e.g. in
/// `EXTRACT(YEAR_MONTH FROM d)` or `INTERVAL '1-2' YEAR_MONTH`.
///
/// [MySQL](https://dev.mysql.com/doc/refman/8.4/en/expressions.html#temporal-intervals)
fn supports_compound_date_time_fields(&self) -> bool {
false
}

/// Returns true if this dialect allows the `EXTRACT` function to use single quotes in the part being extracted.
fn allow_extract_single_quotes(&self) -> bool {
false
Expand Down
5 changes: 5 additions & 0 deletions src/dialect/mysql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ impl Dialect for MySqlDialect {
true
}

/// See: <https://dev.mysql.com/doc/refman/8.4/en/expressions.html#temporal-intervals>
fn supports_compound_date_time_fields(&self) -> bool {
true
}

fn supports_limit_comma(&self) -> bool {
true
}
Expand Down
11 changes: 11 additions & 0 deletions src/keywords.rs
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,10 @@ define_keywords!(
DAYOFWEEK,
DAYOFYEAR,
DAYS,
DAY_HOUR,
DAY_MICROSECOND,
DAY_MINUTE,
DAY_SECOND,
DCPROPERTIES,
DEALLOCATE,
DEC,
Expand Down Expand Up @@ -497,6 +501,9 @@ define_keywords!(
HOSTS,
HOUR,
HOURS,
HOUR_MICROSECOND,
HOUR_MINUTE,
HOUR_SECOND,
HUGEINT,
IAM_ROLE,
ICEBERG,
Expand Down Expand Up @@ -660,6 +667,8 @@ define_keywords!(
MINUS,
MINUTE,
MINUTES,
MINUTE_MICROSECOND,
MINUTE_SECOND,
MINVALUE,
MIN_ROWS,
MOD,
Expand Down Expand Up @@ -936,6 +945,7 @@ define_keywords!(
SECONDARY,
SECONDARY_ENGINE_ATTRIBUTE,
SECONDS,
SECOND_MICROSECOND,
SECRET,
SECURE,
SECURITY,
Expand Down Expand Up @@ -1193,6 +1203,7 @@ define_keywords!(
XOR,
YEAR,
YEARS,
YEAR_MONTH,
YES,
ZEROFILL,
ZONE,
Expand Down
53 changes: 52 additions & 1 deletion src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3338,6 +3338,43 @@ impl<'a> Parser<'a> {
Keyword::TIMEZONE_HOUR => Ok(DateTimeField::TimezoneHour),
Keyword::TIMEZONE_MINUTE => Ok(DateTimeField::TimezoneMinute),
Keyword::TIMEZONE_REGION => Ok(DateTimeField::TimezoneRegion),
Keyword::SECOND_MICROSECOND
if self.dialect.supports_compound_date_time_fields() =>
{
Ok(DateTimeField::SecondMicrosecond)
}
Keyword::MINUTE_MICROSECOND
if self.dialect.supports_compound_date_time_fields() =>
{
Ok(DateTimeField::MinuteMicrosecond)
}
Keyword::MINUTE_SECOND if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::MinuteSecond)
}
Keyword::HOUR_MICROSECOND if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::HourMicrosecond)
}
Keyword::HOUR_SECOND if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::HourSecond)
}
Keyword::HOUR_MINUTE if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::HourMinute)
}
Keyword::DAY_MICROSECOND if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::DayMicrosecond)
}
Keyword::DAY_SECOND if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::DaySecond)
}
Keyword::DAY_MINUTE if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::DayMinute)
}
Keyword::DAY_HOUR if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::DayHour)
}
Keyword::YEAR_MONTH if self.dialect.supports_compound_date_time_fields() => {
Ok(DateTimeField::YearMonth)
}
_ if self.dialect.allow_extract_custom() => {
self.prev_token();
let custom = self.parse_identifier()?;
Expand Down Expand Up @@ -3579,7 +3616,21 @@ impl<'a> Parser<'a> {
| Keyword::TIMEZONE
| Keyword::TIMEZONE_HOUR
| Keyword::TIMEZONE_MINUTE
)
) || (self.dialect.supports_compound_date_time_fields()
&& matches!(
word.keyword,
Keyword::SECOND_MICROSECOND
| Keyword::MINUTE_MICROSECOND
| Keyword::MINUTE_SECOND
| Keyword::HOUR_MICROSECOND
| Keyword::HOUR_SECOND
| Keyword::HOUR_MINUTE
| Keyword::DAY_MICROSECOND
| Keyword::DAY_SECOND
| Keyword::DAY_MINUTE
| Keyword::DAY_HOUR
| Keyword::YEAR_MONTH
))
} else {
false
}
Expand Down
52 changes: 52 additions & 0 deletions tests/sqlparser_mysql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5202,3 +5202,55 @@ fn parse_create_table_engine_name_quoting() {
mysql_and_generic().verified_stmt("CREATE TABLE t (a INT) ENGINE = `InnoDB`");
mysql_and_generic().verified_stmt("CREATE TABLE t (a INT) ENGINE = InnoDB");
}

#[test]
fn parse_compound_date_time_units() {
// https://dev.mysql.com/doc/refman/8.4/en/expressions.html#temporal-intervals
for (unit, expected_field) in [
("SECOND_MICROSECOND", DateTimeField::SecondMicrosecond),
("MINUTE_MICROSECOND", DateTimeField::MinuteMicrosecond),
("MINUTE_SECOND", DateTimeField::MinuteSecond),
("HOUR_MICROSECOND", DateTimeField::HourMicrosecond),
("HOUR_SECOND", DateTimeField::HourSecond),
("HOUR_MINUTE", DateTimeField::HourMinute),
("DAY_MICROSECOND", DateTimeField::DayMicrosecond),
("DAY_SECOND", DateTimeField::DaySecond),
("DAY_MINUTE", DateTimeField::DayMinute),
("DAY_HOUR", DateTimeField::DayHour),
("YEAR_MONTH", DateTimeField::YearMonth),
] {
assert_eq!(
mysql_and_generic().verified_expr(&format!("EXTRACT({unit} FROM d)")),
Expr::Extract {
field: expected_field.clone(),
syntax: ExtractSyntax::From,
expr: Box::new(Expr::Identifier(Ident::new("d"))),
},
);
assert_eq!(
mysql_and_generic().verified_expr(&format!("INTERVAL '1-2' {unit}")),
Expr::Interval(Interval {
value: Box::new(Expr::Value(
Value::SingleQuotedString("1-2".into()).with_empty_span()
)),
leading_field: Some(expected_field),
leading_precision: None,
last_field: None,
fractional_seconds_precision: None,
}),
);
mysql_and_generic().verified_stmt(&format!(
"SELECT DATE_ADD(d, INTERVAL '1-2' {unit}), d + INTERVAL '1-2' {unit} FROM t"
));
}

let dialects = all_dialects_where(|d| {
!d.supports_compound_date_time_fields() && !d.allow_extract_custom()
});
assert_eq!(
dialects.parse_sql_statements("SELECT EXTRACT(YEAR_MONTH FROM d) FROM t"),
Err(ParserError::ParserError(
"Expected: date/time field, found: YEAR_MONTH".to_string()
))
);
}
Loading