feat: add LazyPartition trait for LazyMemoryExec, migrate generate_series to partitions#20369
Open
ethan-tyler wants to merge 4 commits intoapache:mainfrom
Open
feat: add LazyPartition trait for LazyMemoryExec, migrate generate_series to partitions#20369ethan-tyler wants to merge 4 commits intoapache:mainfrom
ethan-tyler wants to merge 4 commits intoapache:mainfrom
Conversation
…tions Signed-off-by: Ethan Urbanski <ethanurbanski@gmail.com>
Signed-off-by: Ethan Urbanski <ethanurbanski@gmail.com>
Signed-off-by: Ethan Urbanski <ethanurbanski@gmail.com>
Signed-off-by: Ethan Urbanski <ethanurbanski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LazyMemoryExecwithSendableRecordBatchStream#13614Rationale for this change
LazyMemoryExeccurrently uses generator closures (LazyBatchGenerator) as its partition interface. This replaces with aLazyPartitiontrait that gives partitions a proper abstraction while keeping the old generator path working through a legacy adapter.generate_series/rangeare migrated to nativeLazyPartitionas the first consumer. Proto roundtrip is updated to handle both native and legacy forms.What changes are included in this PR?
LazyPartitiontrait as the native partition interface forLazyMemoryExecLazyBatchGeneratorPartitionadapter allowing existing generator to workLazyMemoryExec::try_new,LazyMemoryExec::generators,GenerateSeriesTable::as_generator.generate_series/rangemigrated to nativeGenerateSeriesPartitionGenerateSeriesPartitionwith legacy adapter fallbackLazyPartitionAre these changes tested?
yes
cargo test -p datafusion-physical-plan lazy_memory_tests --libcargo test -p datafusion-functions-table generate_series_tests --libcargo test -p datafusion-proto roundtrip_generate_series --test proto_integrationcargo test -p datafusion execution::coop --test core_integrationcargo check -p datafusion-physical-plan -p datafusion-functions-table -p datafusion-proto -p datafusionAre there any user-facing changes?
No.
LazyBatchGeneratorand existing public APIs remain available (deprecated)