Refactor: expose predicate constant inference from physical-expr#21167
Merged
xudong963 merged 3 commits intoapache:mainfrom Mar 31, 2026
Merged
Refactor: expose predicate constant inference from physical-expr#21167xudong963 merged 3 commits intoapache:mainfrom
xudong963 merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
physical-expr
asolimando
approved these changes
Mar 26, 2026
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM, it's nice to expose helpers like this more broadly, it's convenient wherever you have an expression/predicate, which is not necessarily a filter
alamb
approved these changes
Mar 27, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @xudong963 and @asolimando
| split_impl(Operator::And, predicate, vec![]) | ||
| } | ||
|
|
||
| /// Collects predicate-derived constants from equality conjunctions. |
Contributor
There was a problem hiding this comment.
To make this more discoverable (aka a greater chance that someone will be able to find it). I recommend making this a method on ConstExpr
So like
let const_exprs = ConstExpr::collect_predicate_constants(,,)Also, I think an example or two might help (not necessairly code examples, but textural)
…ility Address alamb's review comment: move `collect_predicate_constants` from a standalone function to `ConstExpr::collect_predicate_constants()` and add a textual example to the doc comment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xudong963
added a commit
to massive-com/arrow-datafusion
that referenced
this pull request
Mar 31, 2026
…che#21167) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The predicate constant inference logic is helpful, we also use it in in our product, but we just copied that becuase it's now in the filter's method. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> The PR extracts the related logic into a helper method in physical expr. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit 9c1e7ab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The predicate constant inference logic is helpful, we also use it in in our product, but we just copied that becuase it's now in the filter's method.
What changes are included in this PR?
The PR extracts the related logic into a helper method in physical expr.
Are these changes tested?
Yes
Are there any user-facing changes?