-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: preserve ABFS container in object store registry keys #23935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
847850277
wants to merge
9
commits into
apache:main
Choose a base branch
from
847850277:issues_23926
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−3
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2a638a0
fix: preserve ABFS container in object store registry keys
847850277 8f3f6f9
Merge branch 'main' into issues_23926
847850277 fec42b4
fix: preserve ABFS container in object store registry keys
847850277 9614f4e
fix: update by review.
847850277 ed24f0d
Merge branch 'main' into issues_23926
847850277 86db2f0
Merge branch 'main' into issues_23926
847850277 e20d3ee
Merge branch 'main' into issues_23926
847850277 34a90e5
Merge branch 'main' into issues_23926
847850277 d3e3348
Merge branch 'main' into issues_23926
847850277 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is quite unfortunate that we need to do something abfs specific -- is there some way to make this more general (or hide the object store specific behavior in the object_store crate)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A generic rule cannot distinguish an ABFS container from credential userinfo.
We could preserve usernames for all schemes while excluding passwords, but that would change existing behavior. Alternatively, we could move the key derivation into the object_store crate. Which approach would you prefer?