fix: typo for the builder error type - #24052
Open
JosephLenton wants to merge 2 commits into
Open
Conversation
JosephLenton
force-pushed
the
fix-plan-builder-data-type-error-typo
branch
from
August 2, 2026 11:01
24b04be to
5a0c76f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24052 +/- ##
=======================================
Coverage 80.87% 80.88%
=======================================
Files 1101 1101
Lines 375765 375776 +11
Branches 375765 375776 +11
=======================================
+ Hits 303915 303933 +18
+ Misses 53747 53738 -9
- Partials 18103 18105 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JosephLenton
force-pushed
the
fix-plan-builder-data-type-error-typo
branch
from
August 2, 2026 20:00
3a27e8c to
445d9cb
Compare
JosephLenton
force-pushed
the
fix-plan-builder-data-type-error-typo
branch
from
August 3, 2026 15:53
445d9cb to
bd7234c
Compare
JosephLenton
marked this pull request as ready for review
August 3, 2026 15:54
nuno-faria
approved these changes
Aug 3, 2026
nuno-faria
left a comment
nuno-faria
left a comment
Contributor
There was a problem hiding this comment.
Thanks @JosephLenton, I leave a small suggestion below.
| { | ||
| return exec_err!( | ||
| "type mismatch and can't cast to got {} and {}", | ||
| "Type mismatch and can't cast, received data of type {} for field of type {}", |
Contributor
There was a problem hiding this comment.
The original part sounds a bit odd to me. What do you think about "Types don't match and no valid cast exists, ..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
There is no ticket for this (I can open one if it is really needed). This is a very small nitpick QoL improvement, by changing the wording for an error.
The typo fixes the phrase
... can't cast to got ..., by adding a comma and making the rest a bit clearer.Rationale for this change
... can't cast to got ....gotandforare, by changing todata of typeandfield of type.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?