Skip to content

refactor(hash-aggr): Support spilling for partial and final mode aggregation #24061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2010YOUY01 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(hash-aggr): Support spilling for partial and final mode aggregation #24061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3066f51
feat: implement spilling for migrated partial/final hash aggregation
2010YOUY01 Aug 3, 2026
c11f63f
fix memory accounting bugs
2010YOUY01 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions datafusion/core/tests/memory_limit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ async fn group_by_row_hash() {
TestCase::new()
.with_query("select count(*) from t GROUP BY response_bytes")
.with_expected_errors(vec![
"Resources exhausted: Additional allocation failed", "with top memory consumers (across reservations) as:\n GroupedHashAggregateStream"
"Resources exhausted: Additional allocation failed",
"for FinalHashAggregateStream[0]",
])
.with_memory_limit(2_000)
.run()
Expand All @@ -114,7 +115,8 @@ async fn group_by_hash() {
// group by dict column
.with_query("select count(*) from t GROUP BY service, host, pod, container")
.with_expected_errors(vec![
"Resources exhausted: Additional allocation failed", "with top memory consumers (across reservations) as:\n GroupedHashAggregateStream"
"Resources exhausted: Additional allocation failed",
"for PartialHashAggregateStream[0]",
])
.with_memory_limit(1_000)
.run()
Expand Down Expand Up @@ -425,7 +427,7 @@ async fn oom_grouped_hash_aggregate() {
.with_query("SELECT COUNT(*), SUM(request_bytes) FROM t GROUP BY host")
.with_expected_errors(vec![
"Failed to allocate additional",
"GroupedHashAggregateStream[0] (count(1), sum(t.request_bytes))",
"for PartialHashAggregateStream[0]",
])
.with_memory_limit(1_000)
.run()
Expand Down
Loading
Loading