Skip to content

perf: Concretely typed TopK StringHeap, and StringHashTable slot reuse #24105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MassivePizza wants to merge 23 commits into
base: main
Choose a base branch
from
+244 −305
Draft

perf: Concretely typed TopK StringHeap, and StringHashTable slot reuse #24105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2a56ad5
store concrete type in TopK structures
MassivePizza Jul 14, 2026
14a5c02
store concrete string type in TopK hash-table
MassivePizza Jul 14, 2026
293a0e8
swap in-place in TopK heap
MassivePizza Jul 14, 2026
3b28922
fix error from cherry-pick
MassivePizza Jul 15, 2026
6214dfa
fmt and clippy
MassivePizza Jul 16, 2026
8a7b678
Merge branch 'main' into concrete-topk-storage
MassivePizza Jul 16, 2026
f44bbd9
Merge branch 'main' into concrete-topk-storage
MassivePizza Jul 17, 2026
4fc87b5
Merge branch 'main' into concrete-topk-storage
MassivePizza Jul 23, 2026
0069af0
Merge branch 'main' into concrete-topk-storage
MassivePizza Jul 27, 2026
a82f5fa
remove redundant data_type in PrimitiveHashTable
MassivePizza Jul 27, 2026
dfbf3f9
Undo StringArrayType convenience check,
MassivePizza Jul 27, 2026
5e07c8d
simplify set_batch in PrimitiveHashTable
MassivePizza Jul 27, 2026
55a2e33
replace StringArrayType enum with arrow trait
MassivePizza Aug 3, 2026
22747b1
Merge remote-tracking branch 'upstream/main' into concrete-topk-storage
MassivePizza Aug 3, 2026
e5861d2
use some_value helper
MassivePizza Aug 3, 2026
c5131bd
fix clippy
MassivePizza Aug 4, 2026
8e96042
Merge branch 'main' into concrete-topk-storage
MassivePizza Aug 4, 2026
71ec3cc
share equality closures
MassivePizza Aug 4, 2026
4ba140b
move ID nullability into HashTableItem
MassivePizza Aug 3, 2026
3c248a5
respect null properly in TopKHashTable::null_map_idxs
MassivePizza Aug 4, 2026
6d2db94
concretely typed TopK ArrowHeap storage
MassivePizza Aug 5, 2026
31b45de
reuse (String) allocs in TopKHashTable
MassivePizza Aug 5, 2026
6ed1b35
add use_free_slots comment
MassivePizza Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion-testing
Open in desktop
Submodule datafusion-testing updated 2 files
+0 −55 .github/workflows/codeql.yml
+2 −2 NOTICE.txt
Loading