[Bug] FE metric http_copy_into_query_err_total is registered under the upload error name

[manesioz]

Search before asking

• I had searched in the issues and found no similar issues.

Version

master (573c93c)

What's Wrong?

In MetricRepo, the counter HTTP_COUNTER_COPY_INFO_QUERY_ERR is registered with the name of the upload error counter:

doris/fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java

Lines 834 to 842 in 573c93c

	HTTP_COUNTER_COPY_INFO_UPLOAD_ERR = new LongCounterMetric("http_copy_into_upload_err_total",
	MetricUnit.REQUESTS, "http copy into upload err request");
	DORIS_METRIC_REGISTER.addMetrics(HTTP_COUNTER_COPY_INFO_UPLOAD_ERR);
	HTTP_COUNTER_COPY_INFO_QUERY_REQUEST = new LongCounterMetric("http_copy_into_query_request_total",
	MetricUnit.REQUESTS, "http copy into total query request");
	DORIS_METRIC_REGISTER.addMetrics(HTTP_COUNTER_COPY_INFO_QUERY_REQUEST);
	HTTP_COUNTER_COPY_INFO_QUERY_ERR = new LongCounterMetric("http_copy_into_upload_err_total",
	MetricUnit.REQUESTS, "http copy into err query request");
	DORIS_METRIC_REGISTER.addMetrics(HTTP_COUNTER_COPY_INFO_QUERY_ERR);

HTTP_COUNTER_COPY_INFO_UPLOAD_ERR = new LongCounterMetric("http_copy_into_upload_err_total",
        MetricUnit.REQUESTS, "http copy into upload err request");
...
HTTP_COUNTER_COPY_INFO_QUERY_ERR = new LongCounterMetric("http_copy_into_upload_err_total",
        MetricUnit.REQUESTS, "http copy into err query request");

DorisMetricRegistry keys metrics by name and labels, and MetricList.addMetrics replaces an existing entry with the same key:

doris/fe/fe-core/src/main/java/org/apache/doris/metric/DorisMetricRegistry.java

Lines 42 to 51 in 573c93c

	public void addMetrics(Metric metric) {
	// No metric needs to be added to the Checkpoint thread.
	// And if you add a metric in Checkpoint thread, it will cause the metric to be added repeatedly,
	// and the Checkpoint Catalog may be saved incorrectly, resulting in FE memory leaks.
	if (!Env.isCheckpointThread()) {
	String labelId = computeLabelId(metric.getLabels());
	metrics.computeIfAbsent(metric.getName(), (k) -> new MetricList())
	.addMetrics(labelId, metric);
	}
	}

The query error counter is registered second, so it replaces the upload error counter. As a result:

• doris_fe_http_copy_into_upload_err_total reports the query error count.
• The upload error count is never exported. CopyIntoAction still increments HTTP_COUNTER_COPY_INFO_UPLOAD_ERR, but the registry no longer holds it.
• doris_fe_http_copy_into_query_err_total does not exist.

CopyIntoAction increments HTTP_COUNTER_COPY_INFO_QUERY_ERR only on the query path, so the counter is correct but its name is wrong.

What You Expected?

The query error counter is exported as doris_fe_http_copy_into_query_err_total, which matches the naming of the other three copy-into counters (http_copy_into_upload_request_total, http_copy_into_upload_err_total, http_copy_into_query_request_total).

How to Reproduce?

1. Start an FE.
2. Run curl http://<fe_host>:<http_port>/metrics | grep http_copy_into.
3. doris_fe_http_copy_into_upload_err_total appears once and counts query errors. doris_fe_http_copy_into_query_err_total does not appear.

Anything Else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[Doris-Breakwater]

Confirmed as a valid FE metrics bug at 573c93c63b88fb68ac1d318dcd3e1672dd2361e6. The issue is currently open, unassigned, and has no labels or linked PR.

Verified facts

• HTTP_COUNTER_COPY_INFO_QUERY_ERR is constructed with http_copy_into_upload_err_total; the expected name is http_copy_into_query_err_total.
• CopyIntoAction increments the upload-error and query-error counter objects on their respective paths, so the call sites are already separated correctly.
• There is one important correction to the reported impact: DorisMetricRegistry indexes metrics first by name and then by the computed label set (registration, storage). Both counters have no labels, and the query counter is registered second, so it replaces the upload counter in the registry. On this revision, /metrics should therefore expose one doris_fe_http_copy_into_upload_err_total sample backed by the query-error counter, not two duplicate samples. Upload-error increments occur on an object that is no longer exported, and doris_fe_http_copy_into_query_err_total is absent.

Missing information

No further information is required to confirm or fix the source-level defect. If the endpoint actually emits two identical samples, please attach the exact /metrics lines and confirm the running commit, because that would contradict the registry behavior above and indicate another export path or a different build.

Recommended next steps

1. Change only the query counter's metric name to http_copy_into_query_err_total.
2. Add a focused FE unit test (for example in MetricsTest) asserting that the upload and query error names each resolve to their intended counter object and that Prometheus output contains each series exactly once. This will also catch future name/label collisions that silently replace a metric.
3. Verify after initialization that incrementing each counter changes only its corresponding exported series. No production profile or broader runtime logs are needed for this fix.

This is an observability correctness issue; it does not appear to affect COPY INTO request execution itself. The reporter has offered to submit a PR, and the proposed one-line rename plus regression test is the appropriate scope.

Breakwater-GitHub-Analysis-Slot: slot_fd89ae7b68df

[Doris-Breakwater]

Breakwater triage

Confirmed as a valid FE metrics bug at 573c93c63b88fb68ac1d318dcd3e1672dd2361e6. The issue is currently open, unassigned, and has no labels or linked PR.

Verified facts

• HTTP_COUNTER_COPY_INFO_QUERY_ERR is constructed with http_copy_into_upload_err_total; the expected name is http_copy_into_query_err_total.
• CopyIntoAction increments the upload-error and query-error counter objects on their respective paths, so the call sites are already separated correctly.
• There is one important correction to the reported impact: DorisMetricRegistry indexes metrics first by name and then by the computed label set (registration, storage). Both counters have no labels, and the query counter is registered second, so it replaces the upload counter in the registry. On this revision, /metrics should therefore expose one doris_fe_http_copy_into_upload_err_total sample backed by the query-error counter, not two duplicate samples. Upload-error increments occur on an object that is no longer exported, and doris_fe_http_copy_into_query_err_total is absent.

Missing information

No further information is required to confirm or fix the source-level defect. If the endpoint actually emits two identical samples, please attach the exact /metrics lines and confirm the running commit, because that would contradict the registry behavior above and indicate another export path or a different build.

Recommended next steps

1. Change only the query counter's metric name to http_copy_into_query_err_total.
2. Add a focused FE unit test (for example in MetricsTest) asserting that the upload and query error names each resolve to their intended counter object and that Prometheus output contains each series exactly once. This will also catch future name/label collisions that silently replace a metric.
3. Verify after initialization that incrementing each counter changes only its corresponding exported series. No production profile or broader runtime logs are needed for this fix.

This is an observability correctness issue; it does not appear to affect COPY INTO request execution itself. The reporter has offered to submit a PR, and the proposed one-line rename plus regression test is the appropriate scope.

Breakwater-GitHub-Analysis-Slot: slot_fd89ae7b68df