Skip to content

branch-4.1: [iceberg](fix) Fetch comment PROP from table meta #64263#64308

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-64263-branch-4.1
Jun 17, 2026
Merged

branch-4.1: [iceberg](fix) Fetch comment PROP from table meta #64263#64308
yiguolei merged 1 commit into
branch-4.1from
auto-pick-64263-branch-4.1

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #64263

@github-actions github-actions Bot requested a review from yiguolei as a code owner June 9, 2026 10:01
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

Goal and tests: The PR adds Iceberg external table comment retrieval from Iceberg table/view properties and covers table comment, escaping, and missing-comment behavior with a unit test.
@yiguolei yiguolei force-pushed the auto-pick-64263-branch-4.1 branch from cfc12fd to 106ebee Compare June 16, 2026 08:27
@yiguolei

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 1.06% (1/94) 🎉
Increment coverage report
Complete coverage report

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei yiguolei merged commit 12d1cf1 into branch-4.1 Jun 17, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants