branch-4.1: [fix](mtmv) Avoid mutating excluded trigger tables (#62984)#64519
Open
seawinde wants to merge 1 commit into
Open
branch-4.1: [fix](mtmv) Avoid mutating excluded trigger tables (#62984)#64519seawinde wants to merge 1 commit into
seawinde wants to merge 1 commit into
Conversation
Problem Summary: isMTMVPartitionSync adds followed PCT tables into the excluded trigger table set while checking partition sync. Some callers pass immutable sets, such as the force-consistent rewrite path using ImmutableSet.of(), so partitioned MTMVs can fail with UnsupportedOperationException before the sync check finishes. Copy the input set into a local mutable set before adding derived PCT tables, avoiding mutation of caller-owned state and supporting immutable inputs. --------- Co-authored-by: yangtao555 <yangtao555@jd.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr: #62984
commitId: 464d89c
Backport #62984 to branch-4.1.
This fixes isMTMVPartitionSync mutating caller-owned excluded trigger table sets. The backport adapts the upstream TableNameInfo change to branch-4.1, which still uses TableName in this code path, by copying the input set into a local mutable Set before adding followed PCT tables.
Conflict resolution:
Tests: