[fix](case) test_partition_instance_query_cache: gate plan-shape checks to single BE#64520
Open
shuke987 wants to merge 1 commit into
Open
Conversation
…ks to single BE The query-cache "partition parallelism" plan shape this case asserts (scanInstanceCount == partitionCount, and all of a partition's tablets in one scan instance) only holds when the scan runs on a single BE. On a multi-BE cluster the optimization (UnassignedScanSingleOlapTableJob) legitimately produces one instance per (partition, BE), or -- when totalTablets <= parallelExecInstanceNum * numBE -- falls back to default per-tablet parallelization. So on the P0 multi-BE cluster the case fails for the wrong reason. Gate the single-BE-only plan-shape assertions on a single-BE topology; the result-correctness and cache-consistency checks above still run on any topology. Multi-BE behavior should be covered by a dedicated test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_partition_instance_query_cacheis flaky/failing on the branch-4.1 P0 regression. It asserts the query-cache partition-parallelism plan shape:scanInstanceCount == partitionCountand that all of a partition's tablets land in one scan instance. That shape only holds when the scan runs on a single BE.On a multi-BE cluster the optimization (
UnassignedScanSingleOlapTableJob) legitimately produces one instance per (partition, BE) — or, whentotalTablets <= parallelExecInstanceNum * numBE, falls back to default per-tablet parallelization. So on the multi-BE P0 cluster the case fails for the wrong reason (verified:partitions=3/3butscanInstanceCount=24).Fix
Gate the single-BE-only plan-shape assertions on a single-BE topology (
show backends). The result-correctness and cache-consistency checks above still run on any topology. Multi-BE behavior should be covered by a dedicated test.Verification
Verified on a branch-4.1 cluster: on the multi-BE topology the gated branch is skipped and the suite passes; the data/cache assertions still execute.
🤖 Generated with Claude Code