Skip to content

[fix](regression) keep variant_doc_mode_p2 load in the p2 group with its queries#64533

Open
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-variant-doc-mode-p2-nonconcurrent
Open

[fix](regression) keep variant_doc_mode_p2 load in the p2 group with its queries#64533
shuke987 wants to merge 1 commit into
apache:branch-4.1from
shuke987:fix-variant-doc-mode-p2-nonconcurrent

Conversation

@shuke987

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

In regression_test_variant_doc_mode_p2, load.groovy (which creates and loads the github_events table) is tagged nonConcurrent,p2, while the 76 sql/*.sql query cases in the same directory fall back to the path-derived default group variant_doc_mode_p2 (no nonConcurrent).

nonConcurrent is a separate pipeline, so the load step and the queries get routed to different runs/clusters. In the P2 run the load never executes, and every query fails instantly with:

Table [github_events] does not exist in database [regression_test_variant_doc_mode_p2]

This produced 66 cascade failures in a single branch-4.1 P2 build (e.g. build #35 / 198091), all from the same root cause.

Root cause

The nonConcurrent tag was applied only to load.groovy, not to the dependent queries. The correct nonConcurrent sibling (variant_github_events_nonConcurrent_p2) encodes it in the directory name so the whole suite (load + queries) routes together; variant_doc_mode_p2 instead split the data-prep away from its queries.

The load only sets session variables and does no global-state mutation (no set global / FE-BE config / debug points), so it does not actually need nonConcurrent isolation.

Fix

Drop nonConcurrent so load.groovy shares the p2 group/pipeline with its queries. load.groovy sorts before sql/, runs first, and github_events is present when the queries execute.

-suite("test_doc_value_p2", "nonConcurrent,p2"){
+suite("test_doc_value_p2", "p2"){

Note: the identical structure exists on master (#59183); a follow-up there is advisable.

Release note

None

🤖 Generated with Claude Code

…its queries

`variant_doc_mode_p2/load.groovy` (which creates and loads the
`github_events` table) was tagged `nonConcurrent,p2`, while the 76
`sql/*.sql` query cases under the same directory fall back to the
path-derived default group `variant_doc_mode_p2` (no `nonConcurrent`).

Because `nonConcurrent` is a separate pipeline, the load and the
queries get routed to different runs/clusters. In the P2 run the load
step never executes, so every query fails instantly with
`Table [github_events] does not exist in database
[regression_test_variant_doc_mode_p2]` (66 cascade failures in one
build).

The load only sets session variables and does no global state
mutation (`set global` / FE/BE config / debug points), so it does not
need `nonConcurrent` isolation. Drop the tag so load and queries share
the `p2` group; `load.groovy` sorts before `sql/`, runs first, and the
table is present when the queries run.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@shuke987 shuke987 requested a review from yiguolei as a code owner June 15, 2026 09:57
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants