[fix](regression) keep variant_doc_mode_p2 load in the p2 group with its queries#64533
Open
shuke987 wants to merge 1 commit into
Open
[fix](regression) keep variant_doc_mode_p2 load in the p2 group with its queries#64533shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
…its queries `variant_doc_mode_p2/load.groovy` (which creates and loads the `github_events` table) was tagged `nonConcurrent,p2`, while the 76 `sql/*.sql` query cases under the same directory fall back to the path-derived default group `variant_doc_mode_p2` (no `nonConcurrent`). Because `nonConcurrent` is a separate pipeline, the load and the queries get routed to different runs/clusters. In the P2 run the load step never executes, so every query fails instantly with `Table [github_events] does not exist in database [regression_test_variant_doc_mode_p2]` (66 cascade failures in one build). The load only sets session variables and does no global state mutation (`set global` / FE/BE config / debug points), so it does not need `nonConcurrent` isolation. Drop the tag so load and queries share the `p2` group; `load.groovy` sorts before `sql/`, runs first, and the table is present when the queries run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In
regression_test_variant_doc_mode_p2,load.groovy(which creates and loads thegithub_eventstable) is taggednonConcurrent,p2, while the 76sql/*.sqlquery cases in the same directory fall back to the path-derived default groupvariant_doc_mode_p2(nononConcurrent).nonConcurrentis a separate pipeline, so the load step and the queries get routed to different runs/clusters. In the P2 run the load never executes, and every query fails instantly with:This produced 66 cascade failures in a single branch-4.1 P2 build (e.g. build #35 / 198091), all from the same root cause.
Root cause
The
nonConcurrenttag was applied only toload.groovy, not to the dependent queries. The correct nonConcurrent sibling (variant_github_events_nonConcurrent_p2) encodes it in the directory name so the whole suite (load + queries) routes together;variant_doc_mode_p2instead split the data-prep away from its queries.The load only sets session variables and does no global-state mutation (no
set global/ FE-BE config / debug points), so it does not actually neednonConcurrentisolation.Fix
Drop
nonConcurrentsoload.groovyshares thep2group/pipeline with its queries.load.groovysorts beforesql/, runs first, andgithub_eventsis present when the queries execute.Release note
None
🤖 Generated with Claude Code