branch-4.1: [fix](case) fix mow compaction cases on multi-replica cluster#64538
Open
shuke987 wants to merge 1 commit into
Open
branch-4.1: [fix](case) fix mow compaction cases on multi-replica cluster#64538shuke987 wants to merge 1 commit into
shuke987 wants to merge 1 commit into
Conversation
…ster The three nonConcurrent MOW compaction regression cases (test_mow_compaction_and_read_stale, test_mow_compaction_and_schema_change, test_mow_compaction_agg_and_remove_pre_delete_bitmap) asserted `assertEquals(1, tablets.size())`. `show tablets` returns one row per replica, so on clusters that materialize multiple replicas for the single bucket the assertion fails at table setup (expected: <1> but was: <3>) on the branch-4.1 NonConcurrent pipeline. Assert the real invariant instead -- exactly one distinct tablet (BUCKETS 1) -- by de-duplicating on TabletId, which is independent of replica count. The cases already operate on a single replica via tablets[0], so the downstream compaction / delete-bitmap inspection is unaffected. Related to apache#58662, which relaxed the same check to `tablets.size() >= 1`; this uses a stricter distinct-tablet assertion. The same improvement will be proposed upstream so the branches reconverge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The three nonConcurrent MOW compaction regression cases
test_mow_compaction_and_read_staletest_mow_compaction_and_schema_changetest_mow_compaction_agg_and_remove_pre_delete_bitmapasserted
assertEquals(1, tablets.size())right aftershow tablets.show tabletsreturns one row per replica, so on a cluster thatmaterializes multiple replicas for the single bucket (the branch-4.1
NonConcurrentpipeline creates 3 replicas even when the table requests 1),the assertion fails at table setup:
The 3 rows share the same
TabletId(one bucket, three replicas), e.g.:What does this PR do?
Assert the real invariant instead — exactly one distinct tablet (
BUCKETS 1) —by de-duplicating on
TabletId, which is independent of replica count:The cases already operate on a single replica via
tablets[0], so thedownstream compaction / delete-bitmap inspection is unaffected.
Related to #58662, which relaxed the same check to
tablets.size() >= 1; this uses a stricter distinct-tablet assertion. Thesame improvement will be proposed on master so the branches reconverge.
Release note
None
Check List