[improvement](ai-review) decouple review status from approval permission - #66402
Open
wzz6423 wants to merge 2 commits into
Open
[improvement](ai-review) decouple review status from approval permission#66402wzz6423 wants to merge 2 commits into
wzz6423 wants to merge 2 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #66376
Problem Summary:
The AI reviewer cannot submit a GitHub approval. This change makes the reviewer always submit a COMMENTED review and record a strict PASS or FAIL decision. The workflow verifies the decision and its own comment on the current PR head, then updates the code-review commit status: PASS is success; FAIL, missing/invalid decision, or an execution error is failure.
Release note
The AI reviewer now always submits a COMMENTED review and writes a strict PASS or FAIL decision before posting it. The workflow verifies both the decision and the bot comment on the current head, then sets the code-review commit status to success for PASS or failure for FAIL and execution errors. Subsequent PR sync events preserve these terminal success and failure states.
Check List (For Author)
Test
/reviewrun https://github.com/wzz6423/doris/actions/runs/30869153019 submitted a COMMENTED PASS review and setcode-reviewto success.ready_for_reviewsync https://github.com/wzz6423/doris/actions/runs/30870183860 preserved success.reopenedsync https://github.com/wzz6423/doris/actions/runs/30870261228 preserved an injected failure instead of resetting it to pending.Behavior changed:
Does this need documentation?