Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#68374, apache#63389, apache#65263 Problem Summary: On branch-4.2, sessions currently default to `min_scanners_concurrency = 1` and `enable_expr_zonemap_filter = false`. Set these defaults to `4` and `true`, respectively, and update the English and Chinese session-variable descriptions. This enables the existing expression ZoneMap filtering path by default and raises the minimum scanner concurrency under the existing scanner-count, concurrency and memory limits. Serial scans continue to use one scanner. Both variables remain configurable through the existing session/global settings and are already forwarded to BE. ### Release note Enable expression ZoneMap filtering by default and increase the default `min_scanners_concurrency` from `1` to `4`. ### Check List (For Author) - Test: FE unit tests and Checkstyle passed. - `MAVEN_ARGS='-T 48' bash run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest,org.apache.doris.qe.VariableMgrTest`: 29 tests, 0 failures/errors/skips. - `mvn -T 48 checkstyle:check -pl fe-core` (from `fe/`): 0 violations. - `git diff --check`: passed. - Behavior changed: Yes. The two session defaults change as described above. - Does this need documentation: No. Both session-variable descriptions are updated.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #68374, #63389, #65263
Problem Summary:
On branch-4.2, sessions currently default to
min_scanners_concurrency = 1andenable_expr_zonemap_filter = false. Set these defaults to4andtrue, respectively, and update the English and Chinese session-variable descriptions.This enables the existing expression ZoneMap filtering path by default and raises the minimum scanner concurrency under the existing scanner-count, concurrency and memory limits. Serial scans continue to use one scanner. Both variables remain configurable through the existing session/global settings and are already forwarded to BE.
Release note
Enable expression ZoneMap filtering by default and increase the default
min_scanners_concurrencyfrom1to4.Check List (For Author)
MAVEN_ARGS='-T 48' bash run-fe-ut.sh --run org.apache.doris.qe.SessionVariablesTest,org.apache.doris.qe.VariableMgrTest: 29 tests, 0 failures/errors/skips.mvn -T 48 checkstyle:check -pl fe-core(fromfe/): 0 violations.git diff --check: passed.