Skip to content

[fix](function) Handle constant NULL arrays in array pushback #68380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mryange merged 1 commit into from
Sep 23, 2026
+42 −3
Merged

[fix](function) Handle constant NULL arrays in array pushback #68380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions be/src/exprs/function/array/function_array_pushback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,15 @@ class FunctionArrayPushback : public IFunction {

size_t off = 0;
for (size_t i = 0; i < input_rows_count; ++i) {
if (array_null_map && array_null_map[i]) {
const size_t src_index = index_check_const(i, src_const);
if (array_null_map && array_null_map[src_index]) {
result_null_map[i] = 1;
result_offset_col[i] = off;
continue;
}

size_t src_off = src_offset_col[index_check_const(i, src_const) - 1];
size_t src_len = src_offset_col[index_check_const(i, src_const)] - src_off;
size_t src_off = src_offset_col[src_index - 1];
size_t src_len = src_offset_col[src_index] - src_off;
result_nested_data_col.insert_range_from(src_nested_data_col, src_off, src_len);

result_nested_data_col.insert((*right_column)[index_check_const(i, right_const)]);
Expand Down
36 changes: 36 additions & 0 deletions ...sion-test/data/query_p0/sql_functions/array_functions/test_array_functions_by_literal.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,42 @@ _
-- !sql --
[null, null, null, null, 80]

-- !sql --
0 \N
1 \N
2 \N
3 \N
4 \N
5 \N
6 \N
7 \N
8 \N
9 \N
10 \N
11 \N
12 \N
13 \N
14 \N
15 \N

-- !sql --
0 \N
1 \N
2 \N
3 \N
4 \N
5 \N
6 \N
7 \N
8 \N
9 \N
10 \N
11 \N
12 \N
13 \N
14 \N
15 \N

-- !sql --
[0, 2, 129]

Expand Down
2 changes: 2 additions & 0 deletions ...test/suites/query_p0/sql_functions/array_functions/test_array_functions_by_literal.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,8 @@ suite("test_array_functions_by_literal") {
qt_sql "select array_pushback(array(cast (111.111 as decimalv3(6,3)),cast (222.222 as decimalv3(6,3))), cast (333.333 as decimalv3(6,3)))"
qt_sql "select array_pushback([null,null], null)"
qt_sql "select array_pushback([null,null,null,null], 80)"
qt_sql "select number, array_pushback(cast(null as array<int>), number) from numbers('number'='16') order by number"
qt_sql "select number, array_append(cast(null as array<int>), number) from numbers('number'='16') order by number"

// array_cum_sum
qt_sql "select array_cum_sum([0, 2, 127])"
Expand Down
Loading