Skip to content

[fix](function) Preserve DISTINCT in median percentile conversion #68386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mryange wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

[fix](function) Preserve DISTINCT in median percentile conversion #68386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/MedianConvert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class MedianConvert implements ExpressionPatternRuleFactory {
public List<ExpressionPatternMatcher<? extends Expression>> buildRules() {
return ImmutableList.of(
matchesType(Median.class).then(median ->
new Percentile(median.child(0), DoubleLiteral.of(0.5))
new Percentile(median.isDistinct(), median.child(0), DoubleLiteral.of(0.5))
).toRule(ExpressionRuleType.MEDIAN_CONVERT)
);
}
Expand Down
3 changes: 3 additions & 0 deletions regression-test/data/nereids_rules_p0/expression/test_convert_median_to_percentile.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@
-- !select_6 --
2001 125.5

-- !median_distinct --
5.5 1

13 changes: 13 additions & 0 deletions regression-test/suites/nereids_rules_p0/expression/test_convert_median_to_percentile.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,19 @@ suite("test_convert_median_to_percentile") {
qt_select_5 "${sql5}"
qt_select_6 "${sql6}"

sql "DROP TABLE IF EXISTS median_distinct"
sql """
CREATE TABLE median_distinct (
id INT,
value INT
)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES ("replication_num" = "1")
"""
sql "INSERT INTO median_distinct VALUES (1, 1), (2, 1), (3, 10)"
order_qt_median_distinct "SELECT median(DISTINCT value), median(value) FROM median_distinct"
sql "DROP TABLE IF EXISTS median_distinct"

sql "DROP TABLE if exists sales"
sql "DROP DATABASE if exists test_convert_median_to_percentile"
}
Loading