Skip to content

feat: consolidate S3 client creation and enable ARN role for MSQ export#19317

Open
cecemei wants to merge 3 commits intoapache:masterfrom
cecemei:export2
Open

feat: consolidate S3 client creation and enable ARN role for MSQ export#19317
cecemei wants to merge 3 commits intoapache:masterfrom
cecemei:export2

Conversation

@cecemei
Copy link
Copy Markdown
Contributor

@cecemei cecemei commented Apr 15, 2026

Description

Consolidates the creation of ServerSideEncryptingAmazonS3 into a single static builder method to reduce code duplication and improve maintainability.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cecemei cecemei changed the title feat: support ARN role in MSQ export feat: consolidate S3 client creation and enable ARN role for MSQ export Apr 15, 2026
@cecemei cecemei marked this pull request as ready for review April 15, 2026 04:32
@FrankChen021
Copy link
Copy Markdown
Member

The changes LGTM, no correctness issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants