Skip to content

feat: add PartialQueryableIndex for loading columns on demand #19383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clintropolis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add PartialQueryableIndex for loading columns on demand #19383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion processing/src/main/java/org/apache/druid/segment/IndexIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ private Map<String, Supplier<BaseColumnHolder>> readProjectionColumns(
final Map<String, Supplier<BaseColumnHolder>> projectionColumns = new LinkedHashMap<>();

for (String column : projectionSpec.getSchema().getColumnNames()) {
final String smooshName = Projections.getProjectionSmooshFileName(projectionSpec.getSchema(), column);
final String smooshName = Projections.getProjectionSegmentInternalFileName(projectionSpec.getSchema(), column);
final ByteBuffer colBuffer = segmentFileMapper.mapFile(smooshName);
final ColumnDescriptor columnDescriptor = metadata.getColumnDescriptors().get(smooshName);
if (columnDescriptor == null) {
Expand Down
10 changes: 5 additions & 5 deletions processing/src/main/java/org/apache/druid/segment/IndexMergerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ protected Metadata makeProjections(
columnFormats.put(dimension, dimensionFormat);
DimensionHandler handler = dimensionFormat.getColumnHandler(dimension);
DimensionMergerV9 merger = handler.makeMerger(
Projections.getProjectionSmooshFileName(spec.getSchema(), dimension),
Projections.getProjectionSegmentInternalFileName(spec.getSchema(), dimension),
indexSpec,
segmentWriteOutMedium,
dimensionFormat.toColumnCapabilities(),
Expand Down Expand Up @@ -543,7 +543,7 @@ protected Metadata makeProjections(
metrics,
columnFormats,
indexSpec,
Projections.getProjectionSmooshPrefix(spec.getSchema())
Projections.getProjectionSegmentInternalFilePrefix(spec.getSchema())
);

Function<List<TransformableRowIterator>, TimeAndDimsIterator> rowMergerFn =
Expand Down Expand Up @@ -636,7 +636,7 @@ protected Metadata makeProjections(
progress,
timeWriter,
indexSpec,
Projections.getProjectionSmooshFileName(spec.getSchema(), projectionSchema.getTimeColumnName())
Projections.getProjectionSegmentInternalFileName(spec.getSchema(), projectionSchema.getTimeColumnName())
);
}
makeMetricsColumns(
Expand All @@ -646,7 +646,7 @@ protected Metadata makeProjections(
columnFormats,
metricWriters,
indexSpec,
Projections.getProjectionSmooshPrefix(spec.getSchema())
Projections.getProjectionSegmentInternalFilePrefix(spec.getSchema())
);

for (int i = 0; i < dimensions.size(); i++) {
Expand All @@ -664,7 +664,7 @@ protected Metadata makeProjections(
// use merger descriptor, merger either has values or handles it own null column storage details
columnDesc = merger.makeColumnDescriptor();
}
makeColumn(segmentFileBuilder, Projections.getProjectionSmooshFileName(spec.getSchema(), dimension), columnDesc);
makeColumn(segmentFileBuilder, Projections.getProjectionSegmentInternalFileName(spec.getSchema(), dimension), columnDesc);
}

progress.stopSection(section2);
Expand Down
Loading
Loading