Skip to content

fix: throw clear exception when request parameter is not Serializable #16298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaohmalves wants to merge 2 commits into from
+23 −4
Closed

fix: throw clear exception when request parameter is not Serializable #16298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bd1698
fix: throw clear exception when parameter is not Serializable
joaohmalves May 29, 2026
6605aa2
chore: apply spotless formatting
joaohmalves May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,18 @@ protected void encodeRequestData(Channel channel, ObjectOutput out, Object data,
Object[] args = inv.getArguments();
if (args != null) {
for (int i = 0; i < args.length; i++) {
out.writeObject(callbackServiceCodec.encodeInvocationArgument(channel, inv, i));
Object arg = callbackServiceCodec.encodeInvocationArgument(channel, inv, i);
try {
out.writeObject(arg);
} catch (IOException e) {
Throwable cause = e.getCause() != null ? e.getCause().getCause() : null;
if (cause instanceof IllegalArgumentException
&& cause.getMessage() != null
&& cause.getMessage().contains("has not implement Serializable")) {
throw new IOException(arg.getClass().getName() + " must implement java.io.Serializable", e);
}
throw e;
}
}
}
out.writeAttachments(inv.getObjectAttachments());
Expand All @@ -313,7 +324,17 @@ protected void encodeResponseData(Channel channel, ObjectOutput out, Object data
out.writeByte(attach ? RESPONSE_NULL_VALUE_WITH_ATTACHMENTS : RESPONSE_NULL_VALUE);
} else {
out.writeByte(attach ? RESPONSE_VALUE_WITH_ATTACHMENTS : RESPONSE_VALUE);
out.writeObject(ret);
try {
out.writeObject(ret);
} catch (IOException e) {
Throwable cause = e.getCause() != null ? e.getCause().getCause() : null;
if (cause instanceof IllegalArgumentException
&& cause.getMessage() != null
&& cause.getMessage().contains("has not implement Serializable")) {
throw new IOException(ret.getClass().getName() + " must implement java.io.Serializable", e);
}
throw e;
}
}
} else {
out.writeByte(attach ? RESPONSE_WITH_EXCEPTION_WITH_ATTACHMENTS : RESPONSE_WITH_EXCEPTION);
Expand Down
2 changes: 0 additions & 2 deletions .../dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ void testPerm() {
}

@Test
@Disabled
public void testNonSerializedParameter() {
DemoService service = new DemoServiceImpl();
int port = NetUtils.getAvailablePort();
Expand All @@ -258,7 +257,6 @@ public void testNonSerializedParameter() {
}

@Test
@Disabled
public void testReturnNonSerialized() {
DemoService service = new DemoServiceImpl();
int port = NetUtils.getAvailablePort();
Expand Down
Loading