docs: fix typos in source code comments#21589
Closed
Bojun-Vvibe wants to merge 1 commit intoapache:masterfrom
Closed
docs: fix typos in source code comments#21589Bojun-Vvibe wants to merge 1 commit intoapache:masterfrom
Bojun-Vvibe wants to merge 1 commit intoapache:masterfrom
Conversation
- spcefied -> specified (src/util/graphic.ts) - begining -> beginning (src/component/legend/ScrollableLegendView.ts) - refering -> referring (src/coord/matrix/MatrixBodyCorner.ts)
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo: apache/echarts (⭐ 59000)
Type: docs
Files changed: 3
Lines: +3/-3
What
Fixes three small spelling mistakes in code comments across the ECharts source tree:
spcefied→specifiedinsrc/util/graphic.ts,begining→beginninginsrc/component/legend/ScrollableLegendView.ts, andrefering→referringinsrc/coord/matrix/MatrixBodyCorner.ts.Why
These are pure comment fixes that improve readability and grep-ability of the codebase without changing any runtime behavior. Comments are documentation that contributors and maintainers read regularly, and consistent spelling helps when searching for terms or reviewing diffs.
Testing
No behavioral change — only comment text is modified. The TypeScript compiler treats comments as whitespace, so existing builds and tests remain unaffected. A
git diffconfirms only//comment lines are touched.Risk
Low — comment-only changes with no impact on emitted JavaScript or type-checking.