fix(parallel): preserve areaSelectStyle on persisted selection#21590
Open
fix(parallel): preserve areaSelectStyle on persisted selection#21590
Conversation
|
Thanks for your contribution! The pull request is marked to be |
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21590@0c0f466 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Preserve
parallelAxis.areaSelectStylewhen persisted parallel-axis selections are rebuilt.Fixed issues
areaSelectStyle.Details
Before: What was the problem?
ParallelAxisViewusesareaSelectStylewhen creating a new axis selection, but the persisted covers are later rebuilt throughBrushController.updateCoverswithout carrying over the active brush style. That rebuild path fell back toDEFAULT_BRUSH_OPT, so the selected area eventually changed back to the controller fallback style instead of respecting the configured style.After: How does it behave after the fixing?
BrushController.updateCoversnow inherits from the currently enabled brush option before falling back toDEFAULT_BRUSH_OPT, so rebuilt covers keep the samebrushStyle,transformable, andremoveOnClicksettings as the active controller. A regression test was added to lock this behavior in.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
npx jest --config test/ut/jest.config.cjs --coverage=false test/ut/spec/component/helper/BrushController.test.ts --runInBandnpm run checktypenpx eslint src/component/helper/BrushController.tsMerging options
Other information
N.A.