Skip to content

fix(parallel): preserve areaSelectStyle on persisted selection#21590

Open
Justin-ZS wants to merge 1 commit intomasterfrom
codex/fix-21583-area-select-style
Open

fix(parallel): preserve areaSelectStyle on persisted selection#21590
Justin-ZS wants to merge 1 commit intomasterfrom
codex/fix-21583-area-select-style

Conversation

@Justin-ZS
Copy link
Copy Markdown
Contributor

@Justin-ZS Justin-ZS commented Apr 21, 2026

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Preserve parallelAxis.areaSelectStyle when persisted parallel-axis selections are rebuilt.

Fixed issues

Details

Before: What was the problem?

ParallelAxisView uses areaSelectStyle when creating a new axis selection, but the persisted covers are later rebuilt through BrushController.updateCovers without carrying over the active brush style. That rebuild path fell back to DEFAULT_BRUSH_OPT, so the selected area eventually changed back to the controller fallback style instead of respecting the configured style.

After: How does it behave after the fixing?

BrushController.updateCovers now inherits from the currently enabled brush option before falling back to DEFAULT_BRUSH_OPT, so rebuilt covers keep the same brushStyle, transformable, and removeOnClick settings as the active controller. A regression test was added to lock this behavior in.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • npx jest --config test/ut/jest.config.cjs --coverage=false test/ut/spec/component/helper/BrushController.test.ts --runInBand
  • npm run checktype
  • npx eslint src/component/helper/BrushController.ts

Merging options

  • Please squash the commits into a single one when merging.

Other information

N.A.

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 21, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Justin-ZS Justin-ZS marked this pull request as ready for review April 21, 2026 09:22
@github-actions
Copy link
Copy Markdown
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21590@0c0f466

@Justin-ZS Justin-ZS changed the title [codex] fix persisted parallel areaSelectStyle regression fix(parallel): preserve areaSelectStyle on persisted selection Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant