Skip to content

chore(workflow): disable misleading PR preview comment#21591

Closed
Justin-ZS wants to merge 1 commit intomasterfrom
codex/disable-pr-preview-comment
Closed

chore(workflow): disable misleading PR preview comment#21591
Justin-ZS wants to merge 1 commit intomasterfrom
codex/disable-pr-preview-comment

Conversation

@Justin-ZS
Copy link
Copy Markdown
Contributor

@Justin-ZS Justin-ZS commented Apr 22, 2026

Summary

Disable the auto-generated PR preview comment for now.

The current comment points reviewers to:

https://echarts.apache.org/examples/editor?version=PR-...

But under the current website CSP policy, the editor cannot reliably load the preview bundle hosted on echarts-pr-*.surge.sh, which makes the comment misleading.

This is also consistent with the follow-up change in apache/echarts-examples:

That commit effectively disabled the working PR-preview bundle routing in the editor because the external preview host was no longer reliable under the website CSP.

This change keeps the preview deployment itself unchanged and only disables the confusing PR comment.

Test

  • Workflow-only change

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 22, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@Justin-ZS Justin-ZS requested review from pissang and plainheart April 22, 2026 02:37
Copy link
Copy Markdown
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. This workflow has been removed in #21557. It's currently in the release branch.

@Justin-ZS Justin-ZS closed this Apr 23, 2026
@plainheart plainheart deleted the codex/disable-pr-preview-comment branch April 23, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants