chore(workflow): disable misleading PR preview comment#21591
Closed
chore(workflow): disable misleading PR preview comment#21591
Conversation
|
Thanks for your contribution! The pull request is marked to be To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
plainheart
reviewed
Apr 22, 2026
Member
plainheart
left a comment
There was a problem hiding this comment.
Thanks for your PR. This workflow has been removed in #21557. It's currently in the release branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the auto-generated PR preview comment for now.
The current comment points reviewers to:
https://echarts.apache.org/examples/editor?version=PR-...But under the current website CSP policy, the editor cannot reliably load the preview bundle hosted on
echarts-pr-*.surge.sh, which makes the comment misleading.This is also consistent with the follow-up change in
apache/echarts-examples:use cdn hosted in asf server to avoid csp issueThat commit effectively disabled the working PR-preview bundle routing in the editor because the external preview host was no longer reliable under the website CSP.
This change keeps the preview deployment itself unchanged and only disables the confusing PR comment.
Test