feat(loans): add quick-create modal for loan products (#326) - #543
Merged
Aman-Mittal merged 3 commits intoSep 17, 2026
Merged
Conversation
- Add standalone LoanProductQuickCreateDialogComponent with a 6-field form merged with fixed defaults. - Integrate LoanProductQuickCreateDialogComponent with LoanFormComponent via DialogService for in-context creation. - Add comprehensive unit tests covering validation, creation, dismissal, and error handling.
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 361 passed · 0 failed · 1 skipped · 1 known-failing, across 31 spec files in 6m 36s. 🔒 Known failuresMarked
By spec file
All 363 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 35076951781 from |
Contributor
E2E — real Fineract🎭 E2E Tests✅ All green — 78 passed · 0 failed · 0 skipped, across 24 spec files in 7m 35s. By spec file
All 78 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 35076951781 from |
- Replace direct ModalController/@ngx-translate imports with OVERLAY and I18N adapters per DOCS/adr/0003-adapter-boundary.md - Fix numeric separator lint errors in test file - Fix HttpEvent type mismatch in postLoanproducts test mock - Add LOANS.REPAYMENTS_COUNT and LOANS.REPAYMENT_EVERY keys to hi.json and ko.json (English placeholders pending native translation) Refs apache#326
Member
|
@vaishaldsouza I think this PR alone will not close this issue #326 while work looks good. It needs Playwright test for proper feature closure |
Aman-Mittal
approved these changes
Sep 16, 2026
Member
|
@vaishaldsouza Also add screen shots and videos |
- Add data-testid attributes to quick-create dialog and loan form for e2e targeting (submit, cancel, trigger button, product select) - Add e2e/loan-product-quick-create.spec.ts covering happy path, cancel, and error scenarios against mocked backend Addresses e2e coverage requested in review for apache#326
Member
|
@vaishaldsouza Reverting this as some of the functionality is missing in quick create modal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate LoanProductQuickCreateDialogComponent with LoanFormComponent via DialogService for in-context creation.
Add comprehensive unit tests covering validation, creation, dismissal, and error handling.
What and why
Adds an in-context "+ Create Loan Product" modal to the New Loan Application form so users can create a missing Loan Product without losing form progress, instead of navigating away to Admin settings.
Part of #326
Verification
npm run lint,format:check,test -- --watch=false,build,check:icons,i18n:check, and./scripts/check-license.sh— all pass.Screenshots
AI assistance (optional)
Checklist
src/app/api/.src/app/core/adapters/instead of direct browser globals or imperative third-party APIs.