FINERACT 2289:New command processing - Working Days #5262
Conversation
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
Kidnly review my comments
config/docker/env/mariadb.env
Outdated
| # Interest Rate Chart validation messages | ||
| validation.msg.savings.interestRateChart.slabs.overlap=There is an overlap between slabs {0} and {1}. | ||
| validation.msg.savings.interestRateChart.slabs.gap=There is a gap between slabs {0} and {1}. | ||
| MARIADB_ROOT_PASSWORD=mysql |
There was a problem hiding this comment.
please use another password
There was a problem hiding this comment.
@IOhacker I have updated this. Does the new password work?
| **/.asciidoctor/diagram/* | ||
| **/images/diag-*.svg | ||
|
|
||
| fineract-provider/src/main/generated/ |
There was a problem hiding this comment.
Yes, thank you for pointing that out. I will add it back in.
| @@ -1,4 +1,3 @@ | |||
| # | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
why not use the existing docker compose?
There was a problem hiding this comment.
There wasn't an existing docker compose for MariaDB. @vidakovic wrote this for MariaDB
There was a problem hiding this comment.
Thank you, I have noticed that only Postgres is now implemented.
working days write service pipeline refactored update security config read service refactoring format spotless check validation fixes validation fixes2 fixing updateWorkingDaysTest update tests for auth and tenant based on security config, ran spotless and fixed style issues fixed updaterequest dto and removed generated fixed workingdaysupdaterequest to be backward compatible FINERACT-2289: Fixing working days integration test errors change test to original updated id to resourceId and tests are successful working days write service pipeline refactored update security config read service refactoring format spotless check validation fixes validation fixes2 fixing updateWorkingDaysTest update tests for auth and tenant based on security config, ran spotless and fixed style issues fixed updaterequest dto and removed generated fixed workingdaysupdaterequest to be backward compatible FINERACT-2289: Fixing working days integration test errors
yuwatidora
force-pushed
the
feature/FINERACT-2289
branch
from
e60f124 to
f8a6950
Compare
|
@yuwatidora I am moving this PR into draft because new Command handler does not support: auditing |
3 participants
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Refactoring the Working Days Module as per the New Command Processing Infrastructure.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.