Skip to content

[api][runtime][java] Persist reconciler exceptions as failures#624

Merged
xintongsong merged 3 commits into
apache:mainfrom
joeyutong:codex/reconciler-exception-failures-upstream
Apr 14, 2026
Merged

[api][runtime][java] Persist reconciler exceptions as failures#624
xintongsong merged 3 commits into
apache:mainfrom
joeyutong:codex/reconciler-exception-failures-upstream

Conversation

@joeyutong
Copy link
Copy Markdown
Contributor

@joeyutong joeyutong commented Apr 13, 2026 •
edited by xintongsong
Loading

Linked Issus: #612
Follow-up to #600.

Purpose of change

  • persist reconciler exceptions as recovered terminal failures before rethrowing them
  • align the Java reconciler contract and runtime behavior with that exception semantics
  • update the sync and async reconciler tests to cover failure persistence instead of pending retention

Tests

  • mvn -pl runtime -am spotless:apply
  • mvn -pl runtime -am -Dtest=RunnerContextImplDurableExecuteTest,JavaRunnerContextImplDurableExecuteAsyncTest -Dsurefire.failIfNoSpecifiedTests=false test

Notes

  • This change only covers the Java side. Python runtime and documentation alignment will follow separately.

Documentation

  • doc-needed
  • doc-not-needed
  • doc-included

@github-actions github-actions Bot added doc-label-missing The Bot applies this label either because none or multiple labels were provided. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue. doc-needed Your PR changes impact docs. and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Apr 13, 2026
@github-actions github-actions Bot added doc-needed Your PR changes impact docs. and removed doc-needed Your PR changes impact docs. labels Apr 14, 2026
xintongsong
xintongsong approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong xintongsong mentioned this pull request Apr 14, 2026
Closed
@xintongsong xintongsong merged commit 1a1bf98 into apache:main Apr 14, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xintongsong xintongsong xintongsong approved these changes

Assignees

No one assigned

Labels

doc-needed Your PR changes impact docs. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joeyutong @xintongsong