Skip to content

[test] Avoid Chroma model download in memory test#626

Closed
joeyutong wants to merge 1 commit into
apache:mainfrom
joeyutong:codex/chroma-test-no-download
Closed

[test] Avoid Chroma model download in memory test#626
joeyutong wants to merge 1 commit into
apache:mainfrom
joeyutong:codex/chroma-test-no-download

Conversation

@joeyutong
Copy link
Copy Markdown
Contributor

@joeyutong joeyutong commented Apr 13, 2026

Purpose of change

  • replace the test-only mock embedding with a deterministic local embedding
  • avoid implicit ChromaDB default embedding downloads in non-Ollama test runs
  • keep the unit test focused on long-term memory add/get/search behavior

Tests

  • test_get_memory_set
  • test_add_and_get
  • test_search
  • test_compact skipped; depends on an Ollama server

Documentation

  • doc-needed
  • doc-not-needed
  • doc-included

@github-actions github-actions Bot added doc-label-missing The Bot applies this label either because none or multiple labels were provided. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue. doc-not-needed Your PR changes do not impact docs and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. doc-not-needed Your PR changes do not impact docs labels Apr 13, 2026
@joeyutong joeyutong changed the title [codex] Avoid Chroma model download in memory test [test] Avoid Chroma model download in memory test Apr 14, 2026
@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-not-needed Your PR changes do not impact docs labels Apr 14, 2026
@wenjin272
Copy link
Copy Markdown
Collaborator

Hi, @joeyutong. According to the 0.3 roadmap, we will remove the current implementation of long-term memory and introduce mem0 backend. Consequently, this test will also be removed in the near future.

@joeyutong
Copy link
Copy Markdown
Contributor Author

@wenjin272 Thanks for your update. I'll close this PR.

@joeyutong joeyutong closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants