[FLINK-39577][table] Reuse Calcite's COALESCE to apply simplifications from RexSimplify
#28066
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to you under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.calcite.sql.fun; | ||
|
|
||
| import org.apache.calcite.sql.SqlBasicCall; | ||
| import org.apache.calcite.sql.SqlCall; | ||
| import org.apache.calcite.sql.SqlFunction; | ||
| import org.apache.calcite.sql.SqlFunctionCategory; | ||
| import org.apache.calcite.sql.SqlKind; | ||
| import org.apache.calcite.sql.SqlLiteral; | ||
| import org.apache.calcite.sql.SqlNode; | ||
| import org.apache.calcite.sql.SqlUtil; | ||
| import org.apache.calcite.sql.parser.SqlParserPos; | ||
| import org.apache.calcite.sql.type.OperandTypes; | ||
| import org.apache.calcite.sql.type.ReturnTypes; | ||
| import org.apache.calcite.sql.type.SqlReturnTypeInference; | ||
| import org.apache.calcite.sql.type.SqlTypeTransforms; | ||
| import org.apache.calcite.sql.validate.SqlValidator; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| /** The class copied from Calcite in order to turn off COALESCE rewrite with CASE ... WHEN ... */ | ||
| public class SqlCoalesceFunction extends SqlFunction { | ||
| // ~ Constructors ----------------------------------------------------------- | ||
|
|
||
| public SqlCoalesceFunction() { | ||
| // NOTE jvs 26-July-2006: We fill in the type strategies here, | ||
| // but normally they are not used because the validator invokes | ||
| // rewriteCall to convert COALESCE into CASE early. However, | ||
| // validator rewrite can optionally be disabled, in which case these | ||
| // strategies are used. | ||
| super( | ||
| "COALESCE", | ||
| SqlKind.COALESCE, | ||
| ReturnTypes.LEAST_RESTRICTIVE.andThen(SqlTypeTransforms.LEAST_NULLABLE), | ||
| null, | ||
| OperandTypes.SAME_VARIADIC, | ||
| SqlFunctionCategory.SYSTEM); | ||
| } | ||
|
|
||
| // ~ Methods ---------------------------------------------------------------- | ||
|
|
||
| // ----- FLINK MODIFICATION BEGIN ----- | ||
|
Contributor
Author
There was a problem hiding this comment. In calcite's properties there is a flag to turn it off
Contributor
There was a problem hiding this comment. Can you say more about what this modification does?
Contributor
Author
There was a problem hiding this comment. it's a standard way of marking places in classes copied from Calcite what exactly area is changed in this classes
Contributor
There was a problem hiding this comment. Sorry, I do understand that we are overriding / changing something from Calcite. I am trying to understand what we are changing about the Calcite class.
Contributor
Author
There was a problem hiding this comment. by default Calcite rewrites |
||
| // override SqlOperator | ||
| @Override | ||
| public SqlNode rewriteCall(SqlValidator validator, SqlCall call) { | ||
| validateQuantifier(validator, call); // check DISTINCT/ALL | ||
|
|
||
| List<SqlNode> operands = call.getOperandList(); | ||
|
|
||
| if (operands.size() == 1) { | ||
| return operands.get(0); | ||
| } | ||
|
|
||
| SqlParserPos pos = call.getParserPosition(); | ||
| List<SqlNode> nodes = new ArrayList<>(); | ||
| for (SqlNode operand : operands) { | ||
| if (!SqlUtil.isNullLiteral(operand, false)) { | ||
|
Contributor
There was a problem hiding this comment. Is it intentional that we are not checking for casts? Could something interesting happen if someone trying to cast a wider type to null? |
||
| nodes.add(operand); | ||
| } | ||
| } | ||
|
|
||
| if (nodes.isEmpty()) { | ||
| return SqlLiteral.createNull(pos); | ||
| } | ||
| if (nodes.size() == 1) { | ||
| return nodes.get(0); | ||
| } | ||
|
|
||
| return new SqlBasicCall(this, nodes, pos); | ||
| } | ||
|
|
||
| // ----- FLINK MODIFICATION END ----- | ||
|
|
||
| @Override | ||
| public SqlReturnTypeInference getReturnTypeInference() { | ||
| return requireNonNull(super.getReturnTypeInference(), "returnTypeInference"); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a note that we are removing the NULLs?