[FLINK-39889][table] Thread USING CONNECTION clause into CatalogTable and CreateTableOperation#28385
Open
lihaosky wants to merge 2 commits into
Open
Conversation
Thread the connection identifier from a parsed USING CONNECTION clause in SqlCreateTable through to CatalogTable and the CreateTableOperation. - Add Optional<UnresolvedIdentifier> getConnection() to CatalogTable, a connection() builder method, and the field/accessor in DefaultCatalogTable (equals/hashCode/toString/copy updated). - Delegate getConnection() in ResolvedCatalogTable. - Read SqlCreateTable.getConnection() in AbstractCreateTableConverter and set it on the built CatalogTable. - Serialize/deserialize the connection identifier in CatalogPropertiesUtil under a reserved 'connection.identifier' key, excluded from connector options, so it round-trips and appears in CreateTableOperation summaries. - Add a withConnection() OperationMatcher and tests covering conversion and property serde. Part of FLIP-529.
Collaborator
snuyanzin
reviewed
Jun 14, 2026
| final String sql = "create table derivedTable(\n" + " a int\n" + ")"; | ||
| Operation operation = parseAndConvert(sql); | ||
| assertThat(operation) | ||
| .is(new HamcrestCondition<>(isCreateTableOperation(withConnection(null)))); |
Contributor
There was a problem hiding this comment.
why do we need HamcrestCondition here and can't live without it?
Contributor
Author
There was a problem hiding this comment.
Removed HamcrestCondition here — the tests now cast to CreateTableOperation and assert on getCatalogTable().getConnection() directly with AssertJ. Also dropped the now-unused withConnection matcher from OperationMatchers.
snuyanzin
reviewed
Jun 14, 2026
Comment on lines
+666
to
+670
| "create table derivedTable(\n" | ||
| + " a int\n" | ||
| + ")\n" | ||
| + "USING CONNECTION mycat.mydb.myconn"; | ||
| Operation operation = parseAndConvert(sql); |
Contributor
There was a problem hiding this comment.
case seems mixed
better to have all keywords in uppercase
Contributor
Author
There was a problem hiding this comment.
Good catch — uppercased the keywords (CREATE TABLE, INT) in both tests.
Contributor
|
the PR name seems too generic and says nothing about operation |
…rcase SQL keywords
lihaosky
changed the title
Contributor
Author
|
Renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Part of FLIP-529: Connections in Flink SQL and TableAPI (parent: FLINK-38259).
Threads the connection identifier from a parsed
USING CONNECTIONclause inSqlCreateTable(added in FLINK-39726) through toCatalogTableand theCreateTableOperation, mirroring how the optionaldistributionfield is wired.Brief change log
Optional<UnresolvedIdentifier> getConnection()toCatalogTablewith aconnection()builder method, and the backing field/accessor inDefaultCatalogTable(equals/hashCode/toString/copy updated; existing constructors kept for compatibility).getConnection()inResolvedCatalogTable.SqlCreateTable.getConnection()inAbstractCreateTableConverterand set it on the builtCatalogTable, soCreateTableOperation#getCatalogTable().getConnection()carries the reference.CatalogPropertiesUtilunder a reservedconnection.identifierkey, excluded from connector options, so it round-trips throughtoProperties/fromPropertiesand appears in operation summaries.Verifying this change
This change added tests and can be verified as follows:
SqlDdlToOperationConverterTest#testCreateTableWithConnection/#testCreateTableWithoutConnectionwith a newOperationMatchers#withConnectionmatcher.ResolvedCatalogTableserde case carrying a connection toCatalogPropertiesUtilTest#testCatalogTableSerde.Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (CatalogTable,ResolvedCatalogTablegain an optional getter with a default)Documentation
Was generative AI tooling used to co-author this PR?
Yes