[FLINK-39122][table] Reject out-of-range decimal constant arguments#28437
Open
rionmonster wants to merge 1 commit into
Open
[FLINK-39122][table] Reject out-of-range decimal constant arguments#28437rionmonster wants to merge 1 commit into
rionmonster wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request addresses FLINK-39122 which is related to invalid precision for decimals resulting unexpected in null values. A constant decimal argument that does not fit the declared type (e.g.,
123.456for aDECIMAL(2, 2)parameter) silently producedNULLinstead of raising a type error. The literal is implicitly castable on the type level but overflows on the value level, so it was previous reduced toNULLduring constant folding. These changes introduce validation for constant arguments during type inference so the call fails with aValidationExceptioninstead of producing silent null values.Brief change log
DECIMALtype inTypeInferenceUtil, throwing aValidationExceptionon overflow.Verifying this change
This change added tests and can be verified as follows:
InputTypeStrategiesTest— overflow raises an error; fitting/rounding constants are accepted.ProcessTableFunctionTest— the Table API (fromCall) and SQL paths both raise the error.ProcessTableFunctionSemanticTests— a fitting decimal constant flows through end-to-end.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Generative AI
Reviewer(s) Requested
@twalthr (original reporter)