Conversation
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
The NOTICE fix is right, the pom exclusion does not change anything. Can you correct the description too, it says this removes a bundled dependency and shrinks the jar. On Robert's question about dropping presto-hive, PrestoS3FileSystem is the only presto class this module uses.
| that unnecessarily bloats the bundle. --> | ||
| <exclusion> | ||
| <groupId>org.alluxio</groupId> | ||
| <artifactId>alluxio-shaded-client</artifactId> |
There was a problem hiding this comment.
This is a no-op. org.alluxio is not in this module's tree on master and the shaded jar has no alluxio/ entries. Presto only pulls it via presto-cache, which is already excluded here.
| - io.airlift:slice:0.38 | ||
| - io.airlift:units:1.3 | ||
| - joda-time:joda-time:2.5 | ||
| - org.alluxio:alluxio-shaded-client:2.8.1 |
There was a problem hiding this comment.
software.amazon.ion:ion-java:1.0.2 and javax.xml.bind:jaxb-api:2.3.1 are stale in the same way, want to remove those too? The checker only tolerates them, so CI never complained.
org.alluxio:alluxio-shaded-client is not bundled in flink-s3-fs-presto because presto-cache is already excluded from presto-hive. Similarly, software.amazon.ion:ion-java and javax.xml.bind:jaxb-api are not shaded into the plugin artifact. Drop these stale entries (and the CDDL 1.1 section) from the bundled META-INF/NOTICE file so it accurately reflects the packaged dependencies. Generated-by: Antigravity (Gemini 3.8 Flash)
spuru9
changed the title
3 participants
What is the purpose of the change
flink-s3-fs-prestolistedorg.alluxio:alluxio-shaded-client:2.8.1,software.amazon.ion:ion-java:1.0.2, andjavax.xml.bind:jaxb-api:2.3.1inMETA-INF/NOTICE. However, none of these are actually packaged into the shaded plugin JAR:alluxio-shaded-clientis only referenced bypresto-cache, which is already excluded frompresto-hive.ion-javais a historical entry from older AWS SDK versions that is not pulled in.jaxb-apiis not bundled into the shaded JAR.This cleans up the
META-INF/NOTICEfile to remove these stale entries and the unused CDDL 1.1 license block.Brief change log
org.alluxio:alluxio-shaded-client:2.8.1,software.amazon.ion:ion-java:1.0.2, andjavax.xml.bind:jaxb-api:2.3.1(including the CDDL 1.1 license section) fromflink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE.Verifying this change
Verified that
META-INF/NOTICEaccurately matches the shaded dependencies offlink-s3-fs-prestoand that no required entries are missing.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity (Gemini 3.8 Flash)