-
Notifications
You must be signed in to change notification settings - Fork 14k
[FLINK-40632][s3] Annotate native-s3-fs to PublicEvolving #29159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
|
|
||
| package org.apache.flink.fs.s3native; | ||
|
|
||
| import org.apache.flink.annotation.Experimental; | ||
| import org.apache.flink.annotation.PublicEvolving; | ||
| import org.apache.flink.configuration.ConfigOption; | ||
| import org.apache.flink.configuration.ConfigOptions; | ||
| import org.apache.flink.configuration.Configuration; | ||
|
|
@@ -61,7 +61,7 @@ | |
| * @see NativeS3FileSystem | ||
| * @see org.apache.flink.core.fs.FileSystemFactory | ||
| */ | ||
| @Experimental | ||
| @PublicEvolving | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. Additionally it's not API in Hadoop connector too. |
||
| public class NativeS3FileSystemFactory implements FileSystemFactory, MetricsAware { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(NativeS3FileSystemFactory.class); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
|
|
||
| package org.apache.flink.fs.s3native.writer; | ||
|
|
||
| import org.apache.flink.annotation.Experimental; | ||
| import org.apache.flink.annotation.PublicEvolving; | ||
| import org.apache.flink.core.fs.Path; | ||
| import org.apache.flink.core.fs.RecoverableFsDataOutputStream; | ||
| import org.apache.flink.core.fs.RecoverableWriter; | ||
|
|
@@ -36,7 +36,7 @@ | |
| import static org.apache.flink.util.Preconditions.checkNotNull; | ||
|
|
||
| /** Recoverable writer for S3 using multipart uploads for exactly-once semantics. */ | ||
| @Experimental | ||
| @PublicEvolving | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure why are these part of our API at all? |
||
| public class NativeS3RecoverableWriter implements RecoverableWriter, AutoCloseable { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(NativeS3RecoverableWriter.class); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Additionally it's not API in Hadoop connector too.