Skip to content

[FLINK-40648][metrics] Do not report a metric whose variables collide into one label name - #29171

Open
MartijnVisser wants to merge 1 commit into
apache:masterfrom
MartijnVisser:FLINK-40648-duplicate-label
Open

MartijnVisser wants to merge 1 commit into
apache:masterfrom
MartijnVisser:FLINK-40648-duplicate-label

Conversation

@MartijnVisser

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Two metric group variables that differ only in characters we replace become one label name. Prometheus then rejects the whole scrape, so one such metric costs us every other metric of that process.

Brief change log

  • Stop reporting a metric whose variables collide into one label name
  • Warn once per colliding label name

Verifying this change

This change added tests and can be verified as follows:

  • metricIsNotReportedWhenTwoVariablesSanitiseToTheSameLabelName fails before this change and passes after it

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes, AbstractPrometheusReporter is @PublicEvolving. No signature changes, but a colliding metric that used to be reported no longer is
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (Claude Opus 5)

@flinkbot

flinkbot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

… into one label name

Two metric group variables that differ only in characters the filter replaces
become the same label name. Prometheus rejects such a body and abandons the
whole scrape, so reporting the metric costs every other metric of the process.
Removal has to tolerate a metric that was never registered.

Generated-by: Claude Code (Claude Opus 5)
@MartijnVisser
MartijnVisser force-pushed the FLINK-40648-duplicate-label branch from a46560b to cd40837 Compare September 15, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants