Skip to content

[FLINK-40655][runtime] Fix flaky partition release test #29183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qiuyanjun888 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-40655][runtime] Fix flaky partition release test #29183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ void testResetForNewExecutionReleasesPartitions() throws Exception {

execution.markFinished();

@MartijnVisser MartijnVisser Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both runs linked on the ticket fail at line 95, the assertion before this call. Removing the one after it leaves the flake in place.


assertThat(releasePartitionsFuture).isNotDone();

@MartijnVisser MartijnVisser Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also drops the check that finishing the producer does not release its blocking partitions. The final assertion cannot catch that, since the future keeps whichever release completed first.


for (ExecutionVertex executionVertex : producerExecutionJobVertex.getTaskVertices()) {
executionVertex.resetForNewExecution();
}
Expand Down