[FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false - #29191
Open
1996fanrui wants to merge 1 commit into
Open
[FLINK-40671][network] Document why UnknownInputChannel graduation hardcodes needsRecovery=false#291911996fanrui wants to merge 1 commit into
1996fanrui wants to merge 1 commit into
Conversation
…rdcodes needsRecovery=false
Collaborator
davidradl
reviewed
Sep 15, 2026
| metrics.getNumBytesInRemoteCounter(), | ||
| metrics.getNumBuffersInRemoteCounter(), | ||
| channelStateWriter == null ? ChannelStateWriter.NO_OP : channelStateWriter, | ||
| // Unknown channels exist only in BATCH jobs, which have no channel |
Contributor
There was a problem hiding this comment.
I was expecting a change to the docs from the PR title. Is there an external consideration that we could add to the docs around this? Or is this just for code hygene?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
UnknownInputChannel.toRemoteInputChannel/toLocalInputChannelhardcodeneedsRecovery=falsewhen graduating to a real channel. This looks unsafe next to therecovery path, but it is correct: unknown channels only exist in BATCH jobs, which have no
channel state, while channel-state recovery only exists in streaming (unaligned checkpoints) —
the two are mutually exclusive. This adds a comment documenting that invariant.
Brief change log
UnknownInputChannel.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation