Conversation
…leted_condition argument Whether a LATERAL SNAPSHOT join's load phase completes at compile time or at a user-specified time is now inferred from whether load_completed_time is provided, instead of a separate load_completed_condition argument. Generated-By: Claude Sonnet 5
| } else { | ||
| throw new ValidationException( | ||
| String.format("Unknown SNAPSHOT 'load_completed_condition': '%s'.", condition)); | ||
| loadCompletedTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
should all lateral snapshot functions use the same timestamp? this would make sense and aligns with NOW() semantics of batch systems. let's make this a follow up. we can follow batch and create a config option that get's set when planning starts.
There was a problem hiding this comment.
That's a good point!
I think it shouldn't be too difficult to implement that now. I'll give it a try
| public final class LateralSnapshotJoinUtil { | ||
|
|
||
| /** | ||
| * Label for {@code FlinkLogicalLateralSnapshotJoin#getLoadCompletedCondition()} when the load |
There was a problem hiding this comment.
who uses getLoadCompletedCondition after this change?
There was a problem hiding this comment.
It's only used for EXPLAIN to see whether the load_completed_time was manually set or automatically set at compile time.
… query-start epoch Reuses the query-start epoch time that is set once before the compilation, instead of calling System.currentTimeMillis() per rule match, so multiple compile_time LATERAL SNAPSHOT joins in the same query agree on load_completed_time. Generated-By: Claude Sonnet 5
|
@flinkbot run azure |
|
@twalthr I've added a commit to derive the same timestamp for all SNAPSHOT functions in a query. |
3 participants
What is the purpose of the change
We can simplify the signature and usage of the
SNAPSHOTfunction by removing theload_completed_conditionargument.Instead we infer the condition from the presence of the
load_completed_timeargument.Brief change log
load_completed_conditionargument and all related checksload_completed_timeargument to determine conditionVerifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): no (SNAPSHOTfunction is not released yet)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Sonnet 5