Skip to content

[BP-2.3][FLINK-40675][sql-gateway] Fix unstable SqlGatewayServiceITCase#testReleaseLockWhenFailedToSubmitOperation #29205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
base: release-2.3
Choose a base branch
from
+22 −6
Open

[BP-2.3][FLINK-40675][sql-gateway] Fix unstable SqlGatewayServiceITCase#testReleaseLockWhenFailedToSubmitOperation #29205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions ...gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
import org.apache.flink.test.util.TestUtils;
import org.apache.flink.testutils.executor.TestExecutorExtension;
import org.apache.flink.util.CollectionUtil;
import org.apache.flink.util.ExceptionUtils;
import org.apache.flink.util.UserClassLoaderJarTestUtils;
import org.apache.flink.util.concurrent.ExecutorThreadFactory;
import org.apache.flink.util.function.RunnableWithException;
Expand Down Expand Up @@ -957,14 +958,29 @@ void testReleaseLockWhenFailedToSubmitOperation() throws Exception {
latch.countDown();
// Wait the first operation finishes
awaitOperationTermination(service, sessions.get(0), operations.get(0));
// Service is able to submit operation
// Service is able to submit operation. The first operation turns terminal before its
// thread is back in the pool, so retry until a thread is free.
CountDownLatch success = new CountDownLatch(1);
service.submitOperation(
sessionHandle,
CommonTestUtils.waitUtil(
() -> {
success.countDown();
return getDefaultResultSet();
});
try {
service.submitOperation(
sessionHandle,
() -> {
success.countDown();
return getDefaultResultSet();
});
return true;
} catch (SqlGatewayException e) {
if (ExceptionUtils.findThrowable(e, RejectedExecutionException.class)
.isPresent()) {
return false;
}
throw e;
}
},
Duration.ofSeconds(10),
"The pool never freed a thread to accept the operation.");
CommonTestUtils.waitUtil(
() -> success.getCount() == 0, Duration.ofSeconds(10), "Should come to end.");
}
Expand Down