-
Notifications
You must be signed in to change notification settings - Fork 476
[server] Support generate and execute reblance plan #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
061ed6b to
6bf4aca
Compare
6bf4aca to
d67fc39
Compare
d88c76c to
434a4f4
Compare
d67fc39 to
780e238
Compare
967ccb0 to
85341ca
Compare
60fd7ef to
ed3a37a
Compare
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/zk/data/LeaderAndIsr.java
Outdated
Show resolved
Hide resolved
f391276 to
b03b9eb
Compare
b03b9eb to
270af0a
Compare
270af0a to
911a84e
Compare
5a0e50b to
995e3d2
Compare
995e3d2 to
6d4f006
Compare
...ink-common/src/main/java/org/apache/fluss/flink/procedure/ListRebalanceProcessProcedure.java
Outdated
Show resolved
Hide resolved
...nk/fluss-flink-common/src/main/java/org/apache/fluss/flink/procedure/RebalanceProcedure.java
Outdated
Show resolved
Hide resolved
...s-server/src/main/java/org/apache/fluss/server/coordinator/rebalance/model/ClusterModel.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
...java/org/apache/fluss/server/coordinator/rebalance/goal/ReplicaDistributionAbstractGoal.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/fluss/server/coordinator/rebalance/goal/ReplicaDistributionGoal.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/rebalance/model/ServerModel.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/utils/ServerRpcMessageUtils.java
Outdated
Show resolved
Hide resolved
| } else if (electionStrategy == CONTROLLED_SHUTDOWN_ELECTION) { | ||
| if (electionStrategy instanceof DefaultLeaderElection) { | ||
| resultOpt = | ||
| ((DefaultLeaderElection) electionStrategy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create an issue to refactor ReplicaLeaderElection into interface with method leaderElection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! #2324
| (replica) -> { | ||
| // For rebalance case. the replica state already set to null in method | ||
| // stopRemovedReplicasOfReassignedBucket. so we need not reset it again. | ||
| if (coordinatorContext.getReplicaState(replica) != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that null is a very ambiguous state—would it be better to define a clear, explicit state for use in rebalance scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null is not define only for reblance. NonExist will change the state in coordinatorContext to null.
Purpose
Linked issue: #1397
Brief change log
Tests
API and Format
Documentation