[server] Add authorization to databaseExists and tableExists RPC call…#3078
Open
vaibhavk1992 wants to merge 3 commits intoapache:mainfrom
Open
[server] Add authorization to databaseExists and tableExists RPC call…#3078vaibhavk1992 wants to merge 3 commits intoapache:mainfrom
vaibhavk1992 wants to merge 3 commits intoapache:mainfrom
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds authorization enforcement to “existence check” RPCs to prevent unauthorized users from probing database/table names via databaseExists and tableExists.
Changes:
- Add DESCRIBE authorization checks to
RpcServiceBase.databaseExists()andRpcServiceBase.tableExists(), returningfalsewhen unauthorized to avoid information disclosure. - Add integration tests validating the new “unauthorized => false” behavior for both APIs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fluss-server/src/main/java/org/apache/fluss/server/RpcServiceBase.java | Enforces DESCRIBE authorization for database/table existence checks and hides existence when unauthorized. |
| fluss-client/src/test/java/org/apache/fluss/client/security/acl/FlussAuthorizationITCase.java | Adds IT coverage for unauthorized vs authorized outcomes of databaseExists/tableExists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wuchong
reviewed
Apr 20, 2026
apache#2007) Currently, the databaseExists and tableExists RPC methods do not enforce authorization, allowing any authenticated user to check if databases or tables exist, which poses a security risk. This commit adds authorization checks to both methods: - databaseExists: Checks DESCRIBE permission on the database - tableExists: Checks DESCRIBE permission on the table For security, both methods return false for unauthorized access, preventing information disclosure. Unauthorized users cannot distinguish between "resource doesn't exist" and "no permission", which prevents reconnaissance attacks to map database structure. Changes: - Modified RpcServiceBase.databaseExists() to catch authorization exceptions - Modified RpcServiceBase.tableExists() to catch authorization exceptions - Added testDatabaseExistsAuthorization() integration test - Added testTableExistsAuthorization() integration test Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
wuchong
force-pushed
the
add-authorization-database-table-exists
branch
from
f66bfc9 to
43b39c2
Compare
wuchong
approved these changes
May 5, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
I pushed a commit to address my comments.
Contributor
Author
|
@wuchong Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the databaseExists and tableExists RPC methods do not enforce authorization, allowing any authenticated user to check if databases or tables exist, which poses a security risk.
This commit adds authorization checks to both methods:
For security, both methods return false for unauthorized access, preventing information disclosure. Unauthorized users cannot distinguish between "resource doesn't exist" and "no permission", which prevents reconnaissance attacks to map database structure.
Changes: