[spark] lake table predicate pushdown#3238
Open
fresh-borzoni wants to merge 4 commits intoapache:mainfrom
Open
[spark] lake table predicate pushdown#3238fresh-borzoni wants to merge 4 commits intoapache:mainfrom
fresh-borzoni wants to merge 4 commits intoapache:mainfrom
Conversation
fresh-borzoni
force-pushed
the
feat/spark-lake-filter-pushdown
branch
from
7284ad5 to
15c85e3
Compare
fresh-borzoni
force-pushed
the
feat/spark-lake-filter-pushdown
branch
from
15c85e3 to
a3deed5
Compare
Member
Author
|
@Yohahaha @YannByron PTAL 🙏 |
Yohahaha
approved these changes
May 6, 2026
Contributor
Yohahaha
left a comment
Yohahaha
left a comment
There was a problem hiding this comment.
LGTM! left some comments, thank you!
please update PR title/description to note that partition filter was not implemented.
fresh-borzoni
force-pushed
the
feat/spark-lake-filter-pushdown
branch
from
4f736f4 to
34af92c
Compare
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Spark batch predicate pushdown support for lake-enabled log/kv tables by converting Spark WHERE predicates into Fluss predicates and forwarding them to LakeSource.withFilters(...), aligning Spark behavior more closely with Flink’s lake filter pushdown.
Changes:
- Introduce lake-specific
SupportsPushDownV2Filtershandling that probesLakeSource.withFilters(...)and reports/propagates the accepted predicate subset. - Apply pushed Fluss predicates in lake batch planning and reader factories (lake splits) and wire predicate state through lake scans/batches.
- Add UT coverage for lake append + lake upsert filter pushdown scenarios (lake-only, union with tail, fallback, non-pushable expressions).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/lake/SparkLakeTableReadTestBase.scala | Adds reusable helpers to extract pushed predicates from Spark plans. |
| fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/lake/SparkLakePrimaryKeyTableReadTestBase.scala | Adds primary-key table lake-read filter pushdown tests. |
| fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/lake/SparkLakeLogTableReadTest.scala | Adds append/log lake-read filter pushdown tests (lake-only/union/fallback/non-pushable). |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/utils/SparkPredicateConverter.scala | Refactors predicate conversion to support per-predicate conversion and AND-combination helper. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeUpsertBatch.scala | Threads pushed predicate into lake upsert batch planning and lake source filter application. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakePartitionReaderFactory.scala | Applies lake filters to lake readers and supports passing a separate predicate to log-tail readers. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeBatch.scala | Adds shared applyLakeFilters helper (with debug logging) for LakeSource.withFilters. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeAppendBatch.scala | Threads pushed predicate into lake append planning; optionally forwards to log-tail server-side filter for ARROW. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/FlussScanBuilder.scala | Adds lake-specific V2 filter pushdown trait and wires lake scan builders to it. |
| fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/FlussScan.scala | Propagates pushed Spark predicates into scan descriptions and adds lake scan predicate plumbing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
approved these changes
May 8, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@fresh-borzoni Thanks for the pr. LGTM! One minor comment. Feel free to merge it.
Yohahaha
reviewed
May 8, 2026
| val remaining = result.remainingPredicates().size() | ||
| s"Lake source accepted $accepted of ${accepted + remaining} pushed predicates" | ||
| } | ||
| logDebug( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #3239
Push Spark
WHEREpredicates toLakeSource.withFilters()for batch reads of lake-enabled log and kv tables.Note: partition filter pushdown is not implemented here, I will address this in the followup.