[CORE] Refactor ExpressionConverter to use explicit Option return instead of Option(null)#11757
Merged
zml1206 merged 4 commits intoapache:mainfrom Mar 17, 2026
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@baibaichen can you please review this PR? Thanks! |
zml1206
approved these changes
Mar 16, 2026
acvictor
changed the title
Contributor
Author
Done, thanks for the review! |
zml1206
changed the title
zml1206
reviewed
Mar 17, 2026
Comment on lines
+289
to
+299
| Some(replacePythonUDFWithExpressionTransformer(pythonUDF, attributeSeq, expressionsMap)) | ||
| case scalaUDF: ScalaUDF => | ||
| Some(replaceScalaUDFWithExpressionTransformer(scalaUDF, attributeSeq, expressionsMap)) | ||
| case _ if HiveUDFTransformer.isHiveUDF(expr) => | ||
| Some( | ||
| BackendsApiManager.getSparkPlanExecApiInstance.genHiveUDFTransformer(expr, attributeSeq)) | ||
| case staticInvoke: StaticInvoke => | ||
| Some( | ||
| replaceStaticInvokeWithExpressionTransformer(staticInvoke, attributeSeq, expressionsMap)) | ||
| case invoke: Invoke => | ||
| Some(replaceInvokeWithExpressionTransformer(invoke, attributeSeq, expressionsMap)) |
Contributor
There was a problem hiding this comment.
Please use Option instead of Some to prevent the existence of Some(null), although it should not exist.
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces
Option { expr match { ... case _ => null } }with explicitSome(...)/Nonereturns intryTransformWithoutExpressionMappingto make the intent clearer and avoid the subtle dependency on Option.apply's null-handling behavior.How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No